chrome/browser/extensions/extension_action_icon_factory_unittest.cc - Issue 2152373003: [Extensions] Code Cleanup - Remove redundant smart-ptr get()s

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_action_icon_factory_unittest.cc

Issue 2152373003: [Extensions] Code Cleanup - Remove redundant smart-ptr get()s (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/event_router_forwarder_unittest.cc ('k') | chrome/browser/extensions/extension_action_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_action_icon_factory_unittest.cc

diff --git a/chrome/browser/extensions/extension_action_icon_factory_unittest.cc b/chrome/browser/extensions/extension_action_icon_factory_unittest.cc

index 59a778d6bf88b0b6eac5f2eec3b9b43be2a40851..ca4d9569dd639665c8e81797a7685f30f27f1ddd 100644

--- a/chrome/browser/extensions/extension_action_icon_factory_unittest.cc

+++ b/chrome/browser/extensions/extension_action_icon_factory_unittest.cc

@@ -207,7 +207,7 @@ TEST_P(ExtensionActionIconFactoryTest, NoIcons) {

scoped_refptr<Extension> extension(CreateExtension(

"browser_action/no_icon", Manifest::INVALID_LOCATION));

ASSERT_TRUE(extension.get() != NULL);

- ExtensionAction* browser_action = GetBrowserAction(*extension.get());

+ ExtensionAction* browser_action = GetBrowserAction(*extension);

ASSERT_TRUE(browser_action);

ASSERT_FALSE(browser_action->default_icon());

ASSERT_TRUE(browser_action->GetExplicitlySetIcon(0 /*tab id*/).IsEmpty());

@@ -232,7 +232,7 @@ TEST_P(ExtensionActionIconFactoryTest, AfterSetIcon) {

scoped_refptr<Extension> extension(CreateExtension(

"browser_action/no_icon", Manifest::INVALID_LOCATION));

ASSERT_TRUE(extension.get() != NULL);

- ExtensionAction* browser_action = GetBrowserAction(*extension.get());

+ ExtensionAction* browser_action = GetBrowserAction(*extension);

ASSERT_TRUE(browser_action);

ASSERT_FALSE(browser_action->default_icon());

ASSERT_TRUE(browser_action->GetExplicitlySetIcon(0 /*tab id*/).IsEmpty());

@@ -271,7 +271,7 @@ TEST_P(ExtensionActionIconFactoryTest, DefaultIcon) {

scoped_refptr<Extension> extension(CreateExtension(

"browser_action/no_icon", Manifest::INVALID_LOCATION));

ASSERT_TRUE(extension.get() != NULL);

- ExtensionAction* browser_action = GetBrowserAction(*extension.get());

+ ExtensionAction* browser_action = GetBrowserAction(*extension);

ASSERT_TRUE(browser_action);

ASSERT_FALSE(browser_action->default_icon());

ASSERT_TRUE(browser_action->GetExplicitlySetIcon(0 /*tab id*/).IsEmpty());