chrome/browser/extensions/webstore_standalone_installer.cc - Issue 2152373003: [Extensions] Code Cleanup - Remove redundant smart-ptr get()s

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/webstore_standalone_installer.cc

Issue 2152373003: [Extensions] Code Cleanup - Remove redundant smart-ptr get()s (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/updater/extension_updater_unittest.cc ('k') | chrome/common/extensions/api/commands/commands_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/webstore_standalone_installer.cc

diff --git a/chrome/browser/extensions/webstore_standalone_installer.cc b/chrome/browser/extensions/webstore_standalone_installer.cc

index ac7f2f227c50f0000d7fea7148f56978fd1e499d..6a3f75390356ea35afc0d4518da1dd578284903e 100644

--- a/chrome/browser/extensions/webstore_standalone_installer.cc

+++ b/chrome/browser/extensions/webstore_standalone_installer.cc

@@ -173,8 +173,7 @@ WebstoreStandaloneInstaller::CreateApproval() const {

std::unique_ptr<WebstoreInstaller::Approval> approval(

WebstoreInstaller::Approval::CreateWithNoInstallPrompt(

profile_, id_,

- std::unique_ptr<base::DictionaryValue>(manifest_.get()->DeepCopy()),

- true));

+ std::unique_ptr<base::DictionaryValue>(manifest_->DeepCopy()), true));

approval->skip_post_install_ui = !ShouldShowPostInstallUI();

approval->use_app_installed_bubble = ShouldShowAppInstalledBubble();

approval->installing_icon = gfx::ImageSkia::CreateFrom1xBitmap(icon_);