Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3731)

Unified Diff: extensions/common/file_util_unittest.cc

Issue 2152373003: [Extensions] Code Cleanup - Remove redundant smart-ptr get()s (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/permissions/permission_set_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/file_util_unittest.cc
diff --git a/extensions/common/file_util_unittest.cc b/extensions/common/file_util_unittest.cc
index 41cd4de99651ab890493d15495fcc568be9888dc..2c0662bd26b4becb6b0cfc5d065c302ce427d6d2 100644
--- a/extensions/common/file_util_unittest.cc
+++ b/extensions/common/file_util_unittest.cc
@@ -53,9 +53,8 @@ scoped_refptr<Extension> LoadExtensionManifest(
if (!result.get())
return NULL;
CHECK_EQ(base::Value::TYPE_DICTIONARY, result->GetType());
- return LoadExtensionManifest(
- *base::DictionaryValue::From(std::move(result)).get(), manifest_dir,
- location, extra_flags, error);
+ return LoadExtensionManifest(*base::DictionaryValue::From(std::move(result)),
+ manifest_dir, location, extra_flags, error);
}
} // namespace
@@ -295,8 +294,8 @@ TEST_F(FileUtilTest, BackgroundScriptsMustExist) {
std::string error;
std::vector<extensions::InstallWarning> warnings;
- scoped_refptr<Extension> extension = LoadExtensionManifest(
- *value.get(), temp.path(), Manifest::UNPACKED, 0, &error);
+ scoped_refptr<Extension> extension =
+ LoadExtensionManifest(*value, temp.path(), Manifest::UNPACKED, 0, &error);
ASSERT_TRUE(extension.get()) << error;
EXPECT_FALSE(
@@ -310,8 +309,8 @@ TEST_F(FileUtilTest, BackgroundScriptsMustExist) {
scripts->Clear();
scripts->AppendString("http://google.com/foo.js");
- extension = LoadExtensionManifest(*value.get(), temp.path(),
- Manifest::UNPACKED, 0, &error);
+ extension =
+ LoadExtensionManifest(*value, temp.path(), Manifest::UNPACKED, 0, &error);
ASSERT_TRUE(extension.get()) << error;
warnings.clear();
« no previous file with comments | « chrome/common/extensions/permissions/permission_set_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698