[Extensions] Code Cleanup - Remove redundant smart-ptr get()s

chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/activity_log/fullstream_ui_policy.h"
 
 #include <stdint.h>
 
 #include <memory>
 #include <utility>
@@ skipping 135 matching lines @@
     ASSERT_EQ(2, static_cast<int>(i->size()));
   }
 
   static void RetrieveActions_FetchFilteredActions300(
       std::unique_ptr<std::vector<scoped_refptr<Action>>> i) {
     ASSERT_EQ(300, static_cast<int>(i->size()));
   }
 
   static void Arguments_Present(std::unique_ptr<Action::ActionVector> i) {
     scoped_refptr<Action> last = i->front();
-    CheckAction(*last.get(),
-                "odlameecjipmbmbejkplpemijjgpljce",
-                Action::ACTION_API_CALL,
-                "extension.connect",
-                "[\"hello\",\"world\"]",
-                "",
-                "",
-                "");
+    CheckAction(*last, "odlameecjipmbmbejkplpemijjgpljce",
+                Action::ACTION_API_CALL, "extension.connect",
+                "[\"hello\",\"world\"]", "", "", "");
   }
 
   static void Arguments_GetTodaysActions(
       std::unique_ptr<Action::ActionVector> actions) {
     ASSERT_EQ(2, static_cast<int>(actions->size()));
-    CheckAction(*actions->at(0).get(),
-                "punky",
-                Action::ACTION_DOM_ACCESS,
-                "lets",
-                "[\"vamoose\"]",
-                "http://www.google.com/",
-                "Page Title",
+    CheckAction(*actions->at(0), "punky", Action::ACTION_DOM_ACCESS, "lets",
+                "[\"vamoose\"]", "http://www.google.com/", "Page Title",
                 "http://www.arg-url.com/");
-    CheckAction(*actions->at(1).get(),
-                "punky",
-                Action::ACTION_API_CALL,
-                "brewster",
-                "[\"woof\"]",
-                "",
-                "Page Title",
-                "http://www.arg-url.com/");
+    CheckAction(*actions->at(1), "punky", Action::ACTION_API_CALL, "brewster",
+                "[\"woof\"]", "", "Page Title", "http://www.arg-url.com/");
   }
 
   static void Arguments_GetOlderActions(
       std::unique_ptr<Action::ActionVector> actions) {
     ASSERT_EQ(2, static_cast<int>(actions->size()));
-    CheckAction(*actions->at(0).get(),
-                "punky",
-                Action::ACTION_DOM_ACCESS,
-                "lets",
-                "[\"vamoose\"]",
-                "http://www.google.com/",
-                "",
-                "");
-    CheckAction(*actions->at(1).get(),
-                "punky",
-                Action::ACTION_API_CALL,
-                "brewster",
-                "[\"woof\"]",
-                "",
-                "",
-                "");
+    CheckAction(*actions->at(0), "punky", Action::ACTION_DOM_ACCESS, "lets",
+                "[\"vamoose\"]", "http://www.google.com/", "", "");
+    CheckAction(*actions->at(1), "punky", Action::ACTION_API_CALL, "brewster",
+                "[\"woof\"]", "", "", "");
   }
 
   static void AllURLsRemoved(std::unique_ptr<Action::ActionVector> actions) {
     ASSERT_EQ(2, static_cast<int>(actions->size()));
-    CheckAction(*actions->at(0).get(),
-                "punky",
-                Action::ACTION_API_CALL,
-                "lets",
-                "[\"vamoose\"]",
-                "",
-                "",
-                "");
-    CheckAction(*actions->at(1).get(),
-                "punky",
-                Action::ACTION_DOM_ACCESS,
-                "lets",
-                "[\"vamoose\"]",
-                "",
-                "",
-                "");
+    CheckAction(*actions->at(0), "punky", Action::ACTION_API_CALL, "lets",
+                "[\"vamoose\"]", "", "", "");
+    CheckAction(*actions->at(1), "punky", Action::ACTION_DOM_ACCESS, "lets",
+                "[\"vamoose\"]", "", "", "");
   }
 
   static void SomeURLsRemoved(std::unique_ptr<Action::ActionVector> actions) {
     // These will be in the vector in reverse time order.
     ASSERT_EQ(5, static_cast<int>(actions->size()));
-    CheckAction(*actions->at(0).get(),
-                "punky",
-                Action::ACTION_DOM_ACCESS,
-                "lets",
-                "[\"vamoose\"]",
-                "http://www.google.com/",
-                "Google",
+    CheckAction(*actions->at(0), "punky", Action::ACTION_DOM_ACCESS, "lets",
+                "[\"vamoose\"]", "http://www.google.com/", "Google",
                 "http://www.args-url.com/");
-    CheckAction(*actions->at(1).get(),
-                "punky",
-                Action::ACTION_DOM_ACCESS,
-                "lets",
-                "[\"vamoose\"]",
-                "http://www.google.com/",
-                "Google",
-                "");
-    CheckAction(*actions->at(2).get(),
-                "punky",
-                Action::ACTION_DOM_ACCESS,
-                "lets",
-                "[\"vamoose\"]",
-                "",
-                "",
-                "");
-    CheckAction(*actions->at(3).get(),
-                "punky",
-                Action::ACTION_DOM_ACCESS,
-                "lets",
-                "[\"vamoose\"]",
-                "",
-                "",
-                "http://www.google.com/");
-    CheckAction(*actions->at(4).get(),
-                "punky",
-                Action::ACTION_DOM_ACCESS,
-                "lets",
-                "[\"vamoose\"]",
-                "",
-                "",
-                "");
+    CheckAction(*actions->at(1), "punky", Action::ACTION_DOM_ACCESS, "lets",
+                "[\"vamoose\"]", "http://www.google.com/", "Google", "");
+    CheckAction(*actions->at(2), "punky", Action::ACTION_DOM_ACCESS, "lets",
+                "[\"vamoose\"]", "", "", "");
+    CheckAction(*actions->at(3), "punky", Action::ACTION_DOM_ACCESS, "lets",
+                "[\"vamoose\"]", "", "", "http://www.google.com/");
+    CheckAction(*actions->at(4), "punky", Action::ACTION_DOM_ACCESS, "lets",
+                "[\"vamoose\"]", "", "", "");
   }
 
   static void CheckAction(const Action& action,
                           const std::string& expected_id,
                           const Action::ActionType& expected_type,
                           const std::string& expected_api_name,
                           const std::string& expected_args_str,
                           const std::string& expected_page_url,
                           const std::string& expected_page_title,
                           const std::string& expected_arg_url) {
@@ skipping 62 matching lines @@
     policy->DeleteDatabase();
   }
 
   static void AllActionsDeleted(std::unique_ptr<Action::ActionVector> actions) {
     ASSERT_EQ(0, static_cast<int>(actions->size()));
   }
 
   static void NoActionsDeleted(std::unique_ptr<Action::ActionVector> actions) {
     // These will be in the vector in reverse time order.
     ASSERT_EQ(4, static_cast<int>(actions->size()));
-    CheckAction(*actions->at(0).get(),
-                "punky2",
-                Action::ACTION_API_CALL,
-                "lets2",
-                "[\"vamoose2\"]",
-                "http://www.google2.com/",
-                "Google2",
+    CheckAction(*actions->at(0), "punky2", Action::ACTION_API_CALL, "lets2",
+                "[\"vamoose2\"]", "http://www.google2.com/", "Google2",
                 "http://www.args-url2.com/");
     ASSERT_EQ(3, actions->at(0)->action_id());
-    CheckAction(*actions->at(1).get(),
-                "punky2",
-                Action::ACTION_API_CALL,
-                "lets2",
-                "[\"vamoose2\"]",
-                "http://www.google2.com/",
-                "Google2",
+    CheckAction(*actions->at(1), "punky2", Action::ACTION_API_CALL, "lets2",
+                "[\"vamoose2\"]", "http://www.google2.com/", "Google2",
                 "http://www.args-url2.com/");
     ASSERT_EQ(4, actions->at(1)->action_id());
-    CheckAction(*actions->at(2).get(),
-                "punky1",
-                Action::ACTION_DOM_ACCESS,
-                "lets1",
-                "[\"vamoose1\"]",
-                "http://www.google1.com/",
-                "Google1",
+    CheckAction(*actions->at(2), "punky1", Action::ACTION_DOM_ACCESS, "lets1",
+                "[\"vamoose1\"]", "http://www.google1.com/", "Google1",
                 "http://www.args-url1.com/");
     ASSERT_EQ(1, actions->at(2)->action_id());
-    CheckAction(*actions->at(3).get(),
-                "punky1",
-                Action::ACTION_DOM_ACCESS,
-                "lets1",
-                "[\"vamoose1\"]",
-                "http://www.google1.com/",
-                "Google1",
+    CheckAction(*actions->at(3), "punky1", Action::ACTION_DOM_ACCESS, "lets1",
+                "[\"vamoose1\"]", "http://www.google1.com/", "Google1",
                 "http://www.args-url1.com/");
     ASSERT_EQ(2, actions->at(3)->action_id());
   }
 
   static void Action1Deleted(std::unique_ptr<Action::ActionVector> actions) {
     // These will be in the vector in reverse time order.
     ASSERT_EQ(2, static_cast<int>(actions->size()));
-    CheckAction(*actions->at(0).get(),
-                "punky2",
-                Action::ACTION_API_CALL,
-                "lets2",
-                "[\"vamoose2\"]",
-                "http://www.google2.com/",
-                "Google2",
+    CheckAction(*actions->at(0), "punky2", Action::ACTION_API_CALL, "lets2",
+                "[\"vamoose2\"]", "http://www.google2.com/", "Google2",
                 "http://www.args-url2.com/");
     ASSERT_EQ(3, actions->at(0)->action_id());
-    CheckAction(*actions->at(1).get(),
-                "punky2",
-                Action::ACTION_API_CALL,
-                "lets2",
-                "[\"vamoose2\"]",
-                "http://www.google2.com/",
-                "Google2",
+    CheckAction(*actions->at(1), "punky2", Action::ACTION_API_CALL, "lets2",
+                "[\"vamoose2\"]", "http://www.google2.com/", "Google2",
                 "http://www.args-url2.com/");
     ASSERT_EQ(4, actions->at(1)->action_id());
   }
 
   static void Action2Deleted(std::unique_ptr<Action::ActionVector> actions) {
     // These will be in the vector in reverse time order.
     ASSERT_EQ(2, static_cast<int>(actions->size()));
-    CheckAction(*actions->at(0).get(),
-                "punky1",
-                Action::ACTION_DOM_ACCESS,
-                "lets1",
-                "[\"vamoose1\"]",
-                "http://www.google1.com/",
-                "Google1",
+    CheckAction(*actions->at(0), "punky1", Action::ACTION_DOM_ACCESS, "lets1",
+                "[\"vamoose1\"]", "http://www.google1.com/", "Google1",
                 "http://www.args-url1.com/");
     ASSERT_EQ(1, actions->at(0)->action_id());
-    CheckAction(*actions->at(1).get(),
-                "punky1",
-                Action::ACTION_DOM_ACCESS,
-                "lets1",
-                "[\"vamoose1\"]",
-                "http://www.google1.com/",
-                "Google1",
+    CheckAction(*actions->at(1), "punky1", Action::ACTION_DOM_ACCESS, "lets1",
+                "[\"vamoose1\"]", "http://www.google1.com/", "Google1",
                 "http://www.args-url1.com/");
     ASSERT_EQ(2, actions->at(1)->action_id());
   }
 
  protected:
   ExtensionService* extension_service_;
   std::unique_ptr<TestingProfile> profile_;
   content::TestBrowserThreadBundle thread_bundle_;
 
 #if defined OS_CHROMEOS
@@ skipping 606 matching lines @@
   action_ids.push_back(3);
   action_ids.push_back(4);
   CheckRemoveActions(
       policy, action_ids, base::Bind(&FullStreamUIPolicyTest::Action2Deleted));
   action_ids.clear();
 
   policy->Close();
 }
 
 }  // namespace extensions