chrome/browser/extensions/api/feedback_private/feedback_private_api.cc - Issue 2152373003: [Extensions] Code Cleanup - Remove redundant smart-ptr get()s

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/feedback_private/feedback_private_api.cc

Issue 2152373003: [Extensions] Code Cleanup - Remove redundant smart-ptr get()s (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc ('k') | chrome/browser/extensions/api/file_system/file_system_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/feedback_private/feedback_private_api.cc

diff --git a/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc b/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc

index a9ddaeaeaabe73ba79fb81a73cf736984ae23e95..d439a15bde340178b0997919eb971c2e43a7a276 100644

--- a/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc

+++ b/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc

@@ -259,15 +259,15 @@ bool FeedbackPrivateSendFeedbackFunction::RunAsync() {

feedback_data->set_description(feedback_info.description);

if (feedback_info.category_tag.get())

- feedback_data->set_category_tag(*feedback_info.category_tag.get());

+ feedback_data->set_category_tag(*feedback_info.category_tag);

if (feedback_info.page_url.get())

- feedback_data->set_page_url(*feedback_info.page_url.get());

+ feedback_data->set_page_url(*feedback_info.page_url);

if (feedback_info.email.get())

- feedback_data->set_user_email(*feedback_info.email.get());

+ feedback_data->set_user_email(*feedback_info.email);

if (!attached_file_uuid.empty()) {

feedback_data->set_attached_filename(

- StripFakepath((*feedback_info.attached_file.get()).name));

+ StripFakepath((*feedback_info.attached_file).name));

feedback_data->set_attached_file_uuid(attached_file_uuid);

}

@@ -275,7 +275,7 @@ bool FeedbackPrivateSendFeedbackFunction::RunAsync() {

feedback_data->set_screenshot_uuid(screenshot_uuid);

if (feedback_info.trace_id.get()) {

- feedback_data->set_trace_id(*feedback_info.trace_id.get());

+ feedback_data->set_trace_id(*feedback_info.trace_id);

}

std::unique_ptr<FeedbackData::SystemLogsMap> sys_logs(