chrome/common/extensions/permissions/permission_set_unittest.cc - Issue 2152373003: [Extensions] Code Cleanup - Remove redundant smart-ptr get()s

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/permissions/permission_set_unittest.cc

Issue 2152373003: [Extensions] Code Cleanup - Remove redundant smart-ptr get()s (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_tests/extension_manifests_options_unittest.cc ('k') | extensions/common/file_util_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/permissions/permission_set_unittest.cc

diff --git a/chrome/common/extensions/permissions/permission_set_unittest.cc b/chrome/common/extensions/permissions/permission_set_unittest.cc

index 97125507e01bcf1790cab1ca4e1cf294ccf456b3..1d7eeeadf2fea551d2519fd0bcaca1bbdd721e8d 100644

--- a/chrome/common/extensions/permissions/permission_set_unittest.cc

+++ b/chrome/common/extensions/permissions/permission_set_unittest.cc

@@ -377,9 +377,9 @@ TEST(PermissionsTest, CreateUnion) {

scriptable_hosts2));

union_set = PermissionSet::CreateUnion(*set1, *set2);

EXPECT_TRUE(set1->Contains(*set2));

- EXPECT_TRUE(set1->Contains(*union_set.get()));

+ EXPECT_TRUE(set1->Contains(*union_set));

EXPECT_FALSE(set2->Contains(*set1));

- EXPECT_FALSE(set2->Contains(*union_set.get()));

+ EXPECT_FALSE(set2->Contains(*union_set));

EXPECT_TRUE(union_set->Contains(*set1));

EXPECT_TRUE(union_set->Contains(*set2));

@@ -434,9 +434,9 @@ TEST(PermissionsTest, CreateUnion) {

union_set = PermissionSet::CreateUnion(*set1, *set2);

EXPECT_FALSE(set1->Contains(*set2));

- EXPECT_FALSE(set1->Contains(*union_set.get()));

+ EXPECT_FALSE(set1->Contains(*union_set));

EXPECT_FALSE(set2->Contains(*set1));

- EXPECT_FALSE(set2->Contains(*union_set.get()));

+ EXPECT_FALSE(set2->Contains(*union_set));

EXPECT_TRUE(union_set->Contains(*set1));

EXPECT_TRUE(union_set->Contains(*set2));