chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc - Issue 2152373003: [Extensions] Code Cleanup - Remove redundant smart-ptr get()s

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc

Issue 2152373003: [Extensions] Code Cleanup - Remove redundant smart-ptr get()s (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc ('k') | chrome/browser/extensions/api/bookmarks/bookmarks_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc

diff --git a/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc b/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc

index d465d093824e53df43e43503fad1745cfec9bc4b..122f6a106839c5fcc0baa0d384135b50992d8a6d 100644

--- a/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc

+++ b/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc

@@ -468,7 +468,7 @@ bool BluetoothLowEnergyConnectFunction::DoWork() {

EXTENSION_FUNCTION_VALIDATE(params.get() != NULL);

bool persistent = false; // Not persistent by default.

- apibtle::ConnectProperties* properties = params.get()->properties.get();

+ apibtle::ConnectProperties* properties = params->properties.get();

if (properties)

persistent = properties->persistent;

@@ -901,7 +901,7 @@ bool BluetoothLowEnergyStartCharacteristicNotificationsFunction::DoWork() {

EXTENSION_FUNCTION_VALIDATE(params.get() != NULL);

bool persistent = false; // Not persistent by default.

- apibtle::NotificationProperties* properties = params.get()->properties.get();

+ apibtle::NotificationProperties* properties = params->properties.get();

if (properties)

persistent = properties->persistent;