chrome/common/extensions/api/commands/commands_handler.cc - Issue 2152373003: [Extensions] Code Cleanup - Remove redundant smart-ptr get()s

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/commands/commands_handler.cc

Issue 2152373003: [Extensions] Code Cleanup - Remove redundant smart-ptr get()s (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/webstore_standalone_installer.cc ('k') | chrome/common/extensions/manifest_handlers/settings_overrides_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/commands/commands_handler.cc

diff --git a/chrome/common/extensions/api/commands/commands_handler.cc b/chrome/common/extensions/api/commands/commands_handler.cc

index 6ba153265573340ba392df1440e283172671729b..43870ee92880d69d49a433b7f59a0857daca194a 100644

--- a/chrome/common/extensions/api/commands/commands_handler.cc

+++ b/chrome/common/extensions/api/commands/commands_handler.cc

@@ -118,7 +118,7 @@ bool CommandsHandler::Parse(Extension* extension, base::string16* error) {

commands_info->page_action_command.reset(binding.release());

} else {

if (command_name[0] != '_') // All commands w/underscore are reserved.

- commands_info->named_commands[command_name] = *binding.get();

+ commands_info->named_commands[command_name] = *binding;

}