chrome/browser/extensions/api/webrtc_logging_private/webrtc_event_log_apitest.cc - Issue 2152373003: [Extensions] Code Cleanup - Remove redundant smart-ptr get()s

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/webrtc_logging_private/webrtc_event_log_apitest.cc

Issue 2152373003: [Extensions] Code Cleanup - Remove redundant smart-ptr get()s (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc ('k') | chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/webrtc_logging_private/webrtc_event_log_apitest.cc

diff --git a/chrome/browser/extensions/api/webrtc_logging_private/webrtc_event_log_apitest.cc b/chrome/browser/extensions/api/webrtc_logging_private/webrtc_event_log_apitest.cc

index df04767c80b4ce795de6b068d0b481c385830aa9..fbe243c671236f5ffdc17caca64fb805ddc71f30 100644

--- a/chrome/browser/extensions/api/webrtc_logging_private/webrtc_event_log_apitest.cc

+++ b/chrome/browser/extensions/api/webrtc_logging_private/webrtc_event_log_apitest.cc

@@ -142,7 +142,7 @@ IN_PROC_BROWSER_TEST_F(WebrtcEventLogApiTest,

std::unique_ptr<extensions::api::webrtc_logging_private::RecordingInfo>

recordings_info_start(

extensions::api::webrtc_logging_private::RecordingInfo::FromValue(

- *start_result.get()));

+ *start_result));

ASSERT_TRUE(recordings_info_start.get());

base::FilePath file_name_start(

base::FilePath::FromUTF8Unsafe(recordings_info_start->prefix_path));

@@ -167,7 +167,7 @@ IN_PROC_BROWSER_TEST_F(WebrtcEventLogApiTest,

std::unique_ptr<extensions::api::webrtc_logging_private::RecordingInfo>

recordings_info_stop(

extensions::api::webrtc_logging_private::RecordingInfo::FromValue(

- *stop_result.get()));

+ *stop_result));

ASSERT_TRUE(recordings_info_stop.get());

base::FilePath file_name_stop(

base::FilePath::FromUTF8Unsafe(recordings_info_stop->prefix_path));

@@ -236,7 +236,7 @@ IN_PROC_BROWSER_TEST_F(WebrtcEventLogApiTest,

std::unique_ptr<extensions::api::webrtc_logging_private::RecordingInfo>

recordings_info_start(

extensions::api::webrtc_logging_private::RecordingInfo::FromValue(

- *start_result.get()));

+ *start_result));

ASSERT_TRUE(recordings_info_start.get());

base::FilePath file_name_start(

base::FilePath::FromUTF8Unsafe(recordings_info_start->prefix_path));