Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Side by Side Diff: chrome/browser/extensions/extension_tab_util.cc

Issue 2152373003: [Extensions] Code Cleanup - Remove redundant smart-ptr get()s (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/extension_tab_util.h" 5 #include "chrome/browser/extensions/extension_tab_util.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/strings/string_number_conversions.h" 10 #include "base/strings/string_number_conversions.h"
(...skipping 438 matching lines...) Expand 10 before | Expand all | Expand 10 after
449 449
450 bool api_permission = false; 450 bool api_permission = false;
451 std::string url; 451 std::string url;
452 if (contents) { 452 if (contents) {
453 api_permission = extension->permissions_data()->HasAPIPermissionForTab( 453 api_permission = extension->permissions_data()->HasAPIPermissionForTab(
454 GetTabId(contents), APIPermission::kTab); 454 GetTabId(contents), APIPermission::kTab);
455 url = contents->GetURL().spec(); 455 url = contents->GetURL().spec();
456 } else { 456 } else {
457 api_permission = 457 api_permission =
458 extension->permissions_data()->HasAPIPermission(APIPermission::kTab); 458 extension->permissions_data()->HasAPIPermission(APIPermission::kTab);
459 url = *tab->url.get(); 459 url = *tab->url;
460 } 460 }
461 bool host_permission = extension->permissions_data() 461 bool host_permission = extension->permissions_data()
462 ->active_permissions() 462 ->active_permissions()
463 .HasExplicitAccessToOrigin(GURL(url)); 463 .HasExplicitAccessToOrigin(GURL(url));
464 bool has_permission = api_permission || host_permission; 464 bool has_permission = api_permission || host_permission;
465 if (!has_permission) { 465 if (!has_permission) {
466 tab->url.reset(); 466 tab->url.reset();
467 tab->title.reset(); 467 tab->title.reset();
468 tab->fav_icon_url.reset(); 468 tab->fav_icon_url.reset();
469 } 469 }
(...skipping 199 matching lines...) Expand 10 before | Expand all | Expand 10 after
669 chrome::ShowSingletonTabOverwritingNTP(browser, params); 669 chrome::ShowSingletonTabOverwritingNTP(browser, params);
670 return true; 670 return true;
671 } 671 }
672 672
673 // static 673 // static
674 bool ExtensionTabUtil::BrowserSupportsTabs(Browser* browser) { 674 bool ExtensionTabUtil::BrowserSupportsTabs(Browser* browser) {
675 return browser && browser->tab_strip_model() && !browser->is_devtools(); 675 return browser && browser->tab_strip_model() && !browser->is_devtools();
676 } 676 }
677 677
678 } // namespace extensions 678 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/extensions/extension_service_unittest.cc ('k') | chrome/browser/extensions/install_verifier.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698