Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: chrome/browser/extensions/install_verifier.cc

Issue 2152373003: [Extensions] Code Cleanup - Remove redundant smart-ptr get()s (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/install_verifier.cc
diff --git a/chrome/browser/extensions/install_verifier.cc b/chrome/browser/extensions/install_verifier.cc
index eed45965fde1f268ce9c417a12abf8f53a52fd55..6d10cff1355f478c095b1f70331b783965fe9c1e 100644
--- a/chrome/browser/extensions/install_verifier.cc
+++ b/chrome/browser/extensions/install_verifier.cc
@@ -239,7 +239,7 @@ void InstallVerifier::Init() {
InstallSignature::FromValue(*pref);
if (!signature_from_prefs.get()) {
LogInitResultHistogram(INIT_UNPARSEABLE_PREF);
- } else if (!InstallSigner::VerifySignature(*signature_from_prefs.get())) {
+ } else if (!InstallSigner::VerifySignature(*signature_from_prefs)) {
LogInitResultHistogram(INIT_INVALID_SIGNATURE);
DVLOG(1) << "Init - ignoring invalid signature";
} else {
@@ -458,7 +458,7 @@ ExtensionIdSet InstallVerifier::GetExtensionsToVerify() const {
for (ExtensionSet::const_iterator iter = extensions->begin();
iter != extensions->end();
++iter) {
- if (NeedsVerification(*iter->get()))
+ if (NeedsVerification(**iter))
result.insert((*iter)->id());
}
return result;
@@ -596,10 +596,10 @@ void InstallVerifier::SaveToPrefs() {
if (VLOG_IS_ON(1)) {
DVLOG(1) << "SaveToPrefs - saving";
- DCHECK(InstallSigner::VerifySignature(*signature_.get()));
+ DCHECK(InstallSigner::VerifySignature(*signature_));
std::unique_ptr<InstallSignature> rehydrated =
InstallSignature::FromValue(pref);
- DCHECK(InstallSigner::VerifySignature(*rehydrated.get()));
+ DCHECK(InstallSigner::VerifySignature(*rehydrated));
}
prefs_->SetInstallSignature(&pref);
}
« no previous file with comments | « chrome/browser/extensions/extension_tab_util.cc ('k') | chrome/browser/extensions/permissions_updater_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698