chrome/browser/extensions/api/bookmarks/bookmarks_api.cc - Issue 2152373003: [Extensions] Code Cleanup - Remove redundant smart-ptr get()s

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/bookmarks/bookmarks_api.cc

Issue 2152373003: [Extensions] Code Cleanup - Remove redundant smart-ptr get()s (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc ('k') | chrome/browser/extensions/api/cookies/cookies_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/bookmarks/bookmarks_api.cc

diff --git a/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc b/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc

index a21f74a1cf977b70ef01a244034ff1a9f056dd5b..686b5acda55a4f37f7034806edd482bf1efb6302 100644

--- a/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc

+++ b/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc

@@ -170,11 +170,11 @@ const BookmarkNode* BookmarksFunction::CreateBookmarkNode(

base::string16 title; // Optional.

if (details.title.get())

- title = base::UTF8ToUTF16(*details.title.get());

+ title = base::UTF8ToUTF16(*details.title);

std::string url_string; // Optional.

if (details.url.get())

- url_string = *details.url.get();

+ url_string = *details.url;

GURL url(url_string);

if (!url_string.empty() && !url.is_valid()) {