chrome/common/extensions/manifest_tests/extension_manifests_options_unittest.cc - Issue 2152373003: [Extensions] Code Cleanup - Remove redundant smart-ptr get()s

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_options_unittest.cc

Issue 2152373003: [Extensions] Code Cleanup - Remove redundant smart-ptr get()s (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_handlers/settings_overrides_handler.cc ('k') | chrome/common/extensions/permissions/permission_set_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_tests/extension_manifests_options_unittest.cc

diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_options_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_options_unittest.cc

index 45a46fec41e1000613141b30025a419582246d36..a0d030abdcbf2a7d7545cc8b990d3fc96af8f1f7 100644

--- a/chrome/common/extensions/manifest_tests/extension_manifests_options_unittest.cc

+++ b/chrome/common/extensions/manifest_tests/extension_manifests_options_unittest.cc

@@ -102,12 +102,12 @@ TEST_F(OptionsPageManifestTest, OptionsUIPage) {

scoped_refptr<Extension> extension =

LoadAndExpectSuccess("options_ui_page_basic.json");

EXPECT_EQ(base::StringPrintf("chrome-extension://%s/options.html",

- extension.get()->id().c_str()),

+ extension->id().c_str()),

OptionsPageInfo::GetOptionsPage(extension.get()).spec());

extension = LoadAndExpectSuccess("options_ui_page_with_legacy_page.json");

EXPECT_EQ(base::StringPrintf("chrome-extension://%s/newoptions.html",

- extension.get()->id().c_str()),

+ extension->id().c_str()),

OptionsPageInfo::GetOptionsPage(extension.get()).spec());

Testcase testcases[] = {Testcase("options_ui_page_bad_url.json",