[Extensions] Code Cleanup - Remove redundant smart-ptr get()s

chrome/browser/extensions/install_verifier.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/install_verifier.h"
 
 #include <algorithm>
 #include <string>
 #include <utility>
 
@@ skipping 221 matching lines @@
                             GetExperimentStatus(), VERIFY_STATUS_MAX);
   UMA_HISTOGRAM_ENUMERATION("ExtensionInstallVerifier.ActualStatus",
                             GetStatus(), VERIFY_STATUS_MAX);
 
   const base::DictionaryValue* pref = prefs_->GetInstallSignature();
   if (pref) {
     std::unique_ptr<InstallSignature> signature_from_prefs =
         InstallSignature::FromValue(*pref);
     if (!signature_from_prefs.get()) {
       LogInitResultHistogram(INIT_UNPARSEABLE_PREF);
-    } else if (!InstallSigner::VerifySignature(*signature_from_prefs.get())) {
+    } else if (!InstallSigner::VerifySignature(*signature_from_prefs)) {
       LogInitResultHistogram(INIT_INVALID_SIGNATURE);
       DVLOG(1) << "Init - ignoring invalid signature";
     } else {
       signature_ = std::move(signature_from_prefs);
       LogInitResultHistogram(INIT_VALID_SIGNATURE);
       UMA_HISTOGRAM_COUNTS_100("ExtensionInstallVerifier.InitSignatureCount",
                                signature_->ids.size());
       GarbageCollect();
     }
   } else {
@@ skipping 198 matching lines @@
 InstallVerifier::PendingOperation::~PendingOperation() {
 }
 
 ExtensionIdSet InstallVerifier::GetExtensionsToVerify() const {
   ExtensionIdSet result;
   std::unique_ptr<ExtensionSet> extensions =
       ExtensionRegistry::Get(context_)->GenerateInstalledExtensionsSet();
   for (ExtensionSet::const_iterator iter = extensions->begin();
        iter != extensions->end();
        ++iter) {
-    if (NeedsVerification(*iter->get()))
+    if (NeedsVerification(**iter))
       result.insert((*iter)->id());
   }
   return result;
 }
 
 void InstallVerifier::MaybeBootstrapSelf() {
   bool needs_bootstrap = false;
 
   ExtensionIdSet extension_ids = GetExtensionsToVerify();
   if (signature_.get() == NULL && ShouldFetchSignature()) {
@@ skipping 117 matching lines @@
 
   if (!signature_.get() || signature_->ids.empty()) {
     DVLOG(1) << "SaveToPrefs - saving NULL";
     prefs_->SetInstallSignature(NULL);
   } else {
     base::DictionaryValue pref;
     signature_->ToValue(&pref);
     if (VLOG_IS_ON(1)) {
       DVLOG(1) << "SaveToPrefs - saving";
 
-      DCHECK(InstallSigner::VerifySignature(*signature_.get()));
+      DCHECK(InstallSigner::VerifySignature(*signature_));
       std::unique_ptr<InstallSignature> rehydrated =
           InstallSignature::FromValue(pref);
-      DCHECK(InstallSigner::VerifySignature(*rehydrated.get()));
+      DCHECK(InstallSigner::VerifySignature(*rehydrated));
     }
     prefs_->SetInstallSignature(&pref);
   }
 }
 
 namespace {
 
 enum CallbackResult {
   CALLBACK_NO_SIGNATURE = 0,
   CALLBACK_INVALID_SIGNATURE,
@@ skipping 57 matching lines @@
 ScopedInstallVerifierBypassForTest::~ScopedInstallVerifierBypassForTest() {
   g_bypass_for_test = old_value_;
 }
 
 // static
 bool ScopedInstallVerifierBypassForTest::ShouldBypass() {
   return g_bypass_for_test;
 }
 
 }  // namespace extensions