chrome/browser/extensions/extension_icon_manager_unittest.cc - Issue 2152373003: [Extensions] Code Cleanup - Remove redundant smart-ptr get()s

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_icon_manager_unittest.cc

Issue 2152373003: [Extensions] Code Cleanup - Remove redundant smart-ptr get()s (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_function_test_utils.cc ('k') | chrome/browser/extensions/extension_install_prompt.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_icon_manager_unittest.cc

diff --git a/chrome/browser/extensions/extension_icon_manager_unittest.cc b/chrome/browser/extensions/extension_icon_manager_unittest.cc

index 3edb28522289cf585cd3e14f61367132ad73688f..d474e5c7e6d83e8d3305975fb9af8f0f567a5a62 100644

--- a/chrome/browser/extensions/extension_icon_manager_unittest.cc

+++ b/chrome/browser/extensions/extension_icon_manager_unittest.cc

@@ -117,9 +117,9 @@ TEST_F(ExtensionIconManagerTest, LoadRemoveLoad) {

ASSERT_TRUE(manifest.get() != NULL);

std::string error;

- scoped_refptr<Extension> extension(Extension::Create(

- manifest_path.DirName(), Manifest::INVALID_LOCATION, *manifest.get(),

- Extension::NO_FLAGS, &error));

+ scoped_refptr<Extension> extension(

+ Extension::Create(manifest_path.DirName(), Manifest::INVALID_LOCATION,

+ *manifest, Extension::NO_FLAGS, &error));

ASSERT_TRUE(extension.get());

TestIconManager icon_manager(this);