chrome/browser/extensions/updater/extension_updater.cc - Issue 2152373003: [Extensions] Code Cleanup - Remove redundant smart-ptr get()s

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/updater/extension_updater.cc

Issue 2152373003: [Extensions] Code Cleanup - Remove redundant smart-ptr get()s (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/permissions_updater_unittest.cc ('k') | chrome/browser/extensions/updater/extension_updater_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/updater/extension_updater.cc

diff --git a/chrome/browser/extensions/updater/extension_updater.cc b/chrome/browser/extensions/updater/extension_updater.cc

index db363e6b1747826f7df4bccb22ce345e9a669f83..87f7bb569519497eabd86dd45ee4663869e94db7 100644

--- a/chrome/browser/extensions/updater/extension_updater.cc

+++ b/chrome/browser/extensions/updater/extension_updater.cc

@@ -320,7 +320,7 @@ void ExtensionUpdater::AddToDownloader(

InProgressCheck& request = requests_in_progress_[request_id];

for (ExtensionSet::const_iterator extension_iter = extensions->begin();

extension_iter != extensions->end(); ++extension_iter) {

- const Extension& extension = *extension_iter->get();

+ const Extension& extension = **extension_iter;

if (!Manifest::IsAutoUpdateableLocation(extension.location())) {

VLOG(2) << "Extension " << extension.id() << " is not auto updateable";

continue;