[Extensions] Code Cleanup - Remove redundant smart-ptr get()s

chrome/browser/extensions/api/tabs/tabs_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/tabs/tabs_api.h"
 
 #include <stddef.h>
 #include <algorithm>
 #include <limits>
 #include <memory>
@@ skipping 117 matching lines @@
 
   bool populate_tabs() {
     if (params_->get_info.get() && params_->get_info->populate.get())
       return *params_->get_info->populate;
     return false;
   }
 
   WindowController::TypeFilter type_filters() {
     if (params_->get_info.get() && params_->get_info->window_types.get())
       return WindowController::GetFilterFromWindowTypes(
-          *params_->get_info->window_types.get());
+          *params_->get_info->window_types);
     return WindowController::kNoWindowFilter;
   }
 
  private:
   T* params_;
 };
 
 bool GetBrowserFromWindowID(ChromeUIThreadExtensionFunction* function,
                             int window_id,
                             Browser** browser) {
@@ skipping 53 matching lines @@
 // |value| are equal. This function is used to check if a tab's parameters match
 // those of the browser.
 bool MatchesBool(bool* boolean, bool value) {
   return !boolean || *boolean == value;
 }
 
 template <typename T>
 void AssignOptionalValue(const std::unique_ptr<T>& source,
                          std::unique_ptr<T>& destination) {
   if (source.get()) {
-    destination.reset(new T(*source.get()));
+    destination.reset(new T(*source));
   }
 }
 
 ui::WindowShowState ConvertToWindowShowState(windows::WindowState state) {
   switch (state) {
     case windows::WINDOW_STATE_NORMAL:
     case windows::WINDOW_STATE_DOCKED:
       return ui::SHOW_STATE_NORMAL;
     case windows::WINDOW_STATE_MINIMIZED:
       return ui::SHOW_STATE_MINIMIZED;
@@ skipping 1229 matching lines @@
   }
 
   if (!has_callback())
     return true;
 
   if (num_tabs == 0) {
     error_ = "No tabs given.";
     return false;
   } else if (num_tabs == 1) {
     std::unique_ptr<base::Value> value;
-    CHECK(tab_values.get()->Remove(0, &value));
+    CHECK(tab_values->Remove(0, &value));
     SetResult(std::move(value));
   } else {
     // Only return the results as an array if there are multiple tabs.
     SetResult(std::move(tab_values));
   }
 
   return true;
 }
 
 bool TabsMoveFunction::MoveTab(int tab_id,
@@ skipping 159 matching lines @@
   EXTENSION_FUNCTION_VALIDATE(params.get());
 
   if (params->tab_ids.as_integers) {
     std::vector<int>& tab_ids = *params->tab_ids.as_integers;
     for (size_t i = 0; i < tab_ids.size(); ++i) {
       if (!RemoveTab(tab_ids[i]))
         return false;
     }
   } else {
     EXTENSION_FUNCTION_VALIDATE(params->tab_ids.as_integer);
-    if (!RemoveTab(*params->tab_ids.as_integer.get()))
+    if (!RemoveTab(*params->tab_ids.as_integer))
       return false;
   }
   return true;
 }
 
 bool TabsRemoveFunction::RemoveTab(int tab_id) {
   Browser* browser = NULL;
   WebContents* contents = NULL;
   if (!GetTabById(tab_id,
                   GetProfile(),
@@ skipping 509 matching lines @@
   ZoomModeToZoomSettings(zoom_mode, &zoom_settings);
   zoom_settings.default_zoom_factor.reset(new double(
       content::ZoomLevelToZoomFactor(zoom_controller->GetDefaultZoomLevel())));
 
   results_ = api::tabs::GetZoomSettings::Results::Create(zoom_settings);
   SendResponse(true);
   return true;
 }
 
 }  // namespace extensions