chrome/browser/extensions/api/messaging/extension_message_port.cc - Issue 2152373003: [Extensions] Code Cleanup - Remove redundant smart-ptr get()s

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/messaging/extension_message_port.cc

Issue 2152373003: [Extensions] Code Cleanup - Remove redundant smart-ptr get()s (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/mdns/mdns_api_unittest.cc ('k') | chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/messaging/extension_message_port.cc

diff --git a/chrome/browser/extensions/api/messaging/extension_message_port.cc b/chrome/browser/extensions/api/messaging/extension_message_port.cc

index 6a544a50ff6ba5283d39356c80e921de4cf07e42..19748add8fb64ac1e303e77ede1afb51b2eb8be8 100644

--- a/chrome/browser/extensions/api/messaging/extension_message_port.cc

+++ b/chrome/browser/extensions/api/messaging/extension_message_port.cc

@@ -304,7 +304,7 @@ void ExtensionMessagePort::SendToPort(std::unique_ptr<IPC::Message> msg) {

return;

}

for (content::RenderFrameHost* rfh : frames_) {

- IPC::Message* msg_copy = new IPC::Message(*msg.get());

+ IPC::Message* msg_copy = new IPC::Message(*msg);

msg_copy->set_routing_id(rfh->GetRoutingID());

rfh->Send(msg_copy);

}