[Extensions] Code Cleanup - Remove redundant smart-ptr get()s

chrome/browser/extensions/event_router_forwarder_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/event_router_forwarder.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/power_monitor/power_monitor.h"
@@ skipping 119 matching lines @@
   std::unique_ptr<base::PowerMonitor> dummy;
   // Profiles are weak pointers, owned by ProfileManager in |browser_process_|.
   TestingProfile* profile1_;
   TestingProfile* profile2_;
 };
 
 TEST_F(EventRouterForwarderTest, BroadcastRendererUI) {
   scoped_refptr<MockEventRouterForwarder> event_router(
       new MockEventRouterForwarder);
   GURL url;
-  EXPECT_CALL(*event_router.get(),
-              CallEventRouter(profile1_, "", kHistogramValue, kEventName,
-                              profile1_, url));
-  EXPECT_CALL(*event_router.get(),
-              CallEventRouter(profile2_, "", kHistogramValue, kEventName,
-                              profile2_, url));
+  EXPECT_CALL(*event_router, CallEventRouter(profile1_, "", kHistogramValue,
+                                             kEventName, profile1_, url));
+  EXPECT_CALL(*event_router, CallEventRouter(profile2_, "", kHistogramValue,
+                                             kEventName, profile2_, url));
   BroadcastEventToRenderers(event_router.get(), kHistogramValue, kEventName,
                             url);
 }
 
 TEST_F(EventRouterForwarderTest, BroadcastRendererUIIncognito) {
   scoped_refptr<MockEventRouterForwarder> event_router(
       new MockEventRouterForwarder);
   using ::testing::_;
   GURL url;
   Profile* incognito = profile1_->GetOffTheRecordProfile();
-  EXPECT_CALL(*event_router.get(),
-              CallEventRouter(profile1_, "", kHistogramValue, kEventName,
-                              profile1_, url));
-  EXPECT_CALL(*event_router.get(), CallEventRouter(incognito, _, _, _, _, _))
+  EXPECT_CALL(*event_router, CallEventRouter(profile1_, "", kHistogramValue,
+                                             kEventName, profile1_, url));
+  EXPECT_CALL(*event_router, CallEventRouter(incognito, _, _, _, _, _))
       .Times(0);
-  EXPECT_CALL(*event_router.get(),
-              CallEventRouter(profile2_, "", kHistogramValue, kEventName,
-                              profile2_, url));
+  EXPECT_CALL(*event_router, CallEventRouter(profile2_, "", kHistogramValue,
+                                             kEventName, profile2_, url));
   BroadcastEventToRenderers(event_router.get(), kHistogramValue, kEventName,
                             url);
 }
 
 // This is the canonical test for passing control flow from the IO thread
 // to the UI thread. Repeating this for all public functions of
 // EventRouterForwarder would not increase coverage.
 TEST_F(EventRouterForwarderTest, BroadcastRendererIO) {
   scoped_refptr<MockEventRouterForwarder> event_router(
       new MockEventRouterForwarder);
   GURL url;
-  EXPECT_CALL(*event_router.get(),
-              CallEventRouter(profile1_, "", kHistogramValue, kEventName,
-                              profile1_, url));
-  EXPECT_CALL(*event_router.get(),
-              CallEventRouter(profile2_, "", kHistogramValue, kEventName,
-                              profile2_, url));
+  EXPECT_CALL(*event_router, CallEventRouter(profile1_, "", kHistogramValue,
+                                             kEventName, profile1_, url));
+  EXPECT_CALL(*event_router, CallEventRouter(profile2_, "", kHistogramValue,
+                                             kEventName, profile2_, url));
   BrowserThread::PostTask(BrowserThread::IO, FROM_HERE,
                           base::Bind(&BroadcastEventToRenderers,
                                      base::Unretained(event_router.get()),
                                      kHistogramValue, kEventName, url));
 
   // Wait for IO thread's message loop to be processed
   scoped_refptr<base::ThreadTestHelper> helper(new base::ThreadTestHelper(
       BrowserThread::GetTaskRunnerForThread(BrowserThread::IO).get()));
   ASSERT_TRUE(helper->Run());
 
   base::RunLoop().RunUntilIdle();
 }
 
 TEST_F(EventRouterForwarderTest, UnicastRendererUIRestricted) {
   scoped_refptr<MockEventRouterForwarder> event_router(
       new MockEventRouterForwarder);
   using ::testing::_;
   GURL url;
-  EXPECT_CALL(*event_router.get(),
-              CallEventRouter(profile1_, "", kHistogramValue, kEventName,
-                              profile1_, url));
-  EXPECT_CALL(*event_router.get(), CallEventRouter(profile2_, _, _, _, _, _))
+  EXPECT_CALL(*event_router, CallEventRouter(profile1_, "", kHistogramValue,
+                                             kEventName, profile1_, url));
+  EXPECT_CALL(*event_router, CallEventRouter(profile2_, _, _, _, _, _))
       .Times(0);
   DispatchEventToRenderers(event_router.get(), kHistogramValue, kEventName,
                            profile1_, true, url);
 }
 
 TEST_F(EventRouterForwarderTest, UnicastRendererUIRestrictedIncognito1) {
   scoped_refptr<MockEventRouterForwarder> event_router(
       new MockEventRouterForwarder);
   Profile* incognito = profile1_->GetOffTheRecordProfile();
   using ::testing::_;
   GURL url;
-  EXPECT_CALL(*event_router.get(),
-              CallEventRouter(profile1_, "", kHistogramValue, kEventName,
-                              profile1_, url));
-  EXPECT_CALL(*event_router.get(), CallEventRouter(incognito, _, _, _, _, _))
+  EXPECT_CALL(*event_router, CallEventRouter(profile1_, "", kHistogramValue,
+                                             kEventName, profile1_, url));
+  EXPECT_CALL(*event_router, CallEventRouter(incognito, _, _, _, _, _))
       .Times(0);
-  EXPECT_CALL(*event_router.get(), CallEventRouter(profile2_, _, _, _, _, _))
+  EXPECT_CALL(*event_router, CallEventRouter(profile2_, _, _, _, _, _))
       .Times(0);
   DispatchEventToRenderers(event_router.get(), kHistogramValue, kEventName,
                            profile1_, true, url);
 }
 
 TEST_F(EventRouterForwarderTest, UnicastRendererUIRestrictedIncognito2) {
   scoped_refptr<MockEventRouterForwarder> event_router(
       new MockEventRouterForwarder);
   Profile* incognito = profile1_->GetOffTheRecordProfile();
   using ::testing::_;
   GURL url;
-  EXPECT_CALL(*event_router.get(), CallEventRouter(profile1_, _, _, _, _, _))
+  EXPECT_CALL(*event_router, CallEventRouter(profile1_, _, _, _, _, _))
       .Times(0);
-  EXPECT_CALL(*event_router.get(),
-              CallEventRouter(incognito, "", kHistogramValue, kEventName,
-                              incognito, url));
-  EXPECT_CALL(*event_router.get(), CallEventRouter(profile2_, _, _, _, _, _))
+  EXPECT_CALL(*event_router, CallEventRouter(incognito, "", kHistogramValue,
+                                             kEventName, incognito, url));
+  EXPECT_CALL(*event_router, CallEventRouter(profile2_, _, _, _, _, _))
       .Times(0);
   DispatchEventToRenderers(event_router.get(), kHistogramValue, kEventName,
                            incognito, true, url);
 }
 
 TEST_F(EventRouterForwarderTest, UnicastRendererUIUnrestricted) {
   scoped_refptr<MockEventRouterForwarder> event_router(
       new MockEventRouterForwarder);
   using ::testing::_;
   GURL url;
-  EXPECT_CALL(
-      *event_router.get(),
-      CallEventRouter(profile1_, "", kHistogramValue, kEventName, NULL, url));
-  EXPECT_CALL(*event_router.get(), CallEventRouter(profile2_, _, _, _, _, _))
+  EXPECT_CALL(*event_router, CallEventRouter(profile1_, "", kHistogramValue,
+                                             kEventName, NULL, url));
+  EXPECT_CALL(*event_router, CallEventRouter(profile2_, _, _, _, _, _))
       .Times(0);
   DispatchEventToRenderers(event_router.get(), kHistogramValue, kEventName,
                            profile1_, false, url);
 }
 
 TEST_F(EventRouterForwarderTest, UnicastRendererUIUnrestrictedIncognito) {
   scoped_refptr<MockEventRouterForwarder> event_router(
       new MockEventRouterForwarder);
   Profile* incognito = profile1_->GetOffTheRecordProfile();
   using ::testing::_;
   GURL url;
-  EXPECT_CALL(
-      *event_router.get(),
-      CallEventRouter(profile1_, "", kHistogramValue, kEventName, NULL, url));
-  EXPECT_CALL(*event_router.get(), CallEventRouter(incognito, _, _, _, _, _))
+  EXPECT_CALL(*event_router, CallEventRouter(profile1_, "", kHistogramValue,
+                                             kEventName, NULL, url));
+  EXPECT_CALL(*event_router, CallEventRouter(incognito, _, _, _, _, _))
       .Times(0);
-  EXPECT_CALL(*event_router.get(), CallEventRouter(profile2_, _, _, _, _, _))
+  EXPECT_CALL(*event_router, CallEventRouter(profile2_, _, _, _, _, _))
       .Times(0);
   DispatchEventToRenderers(event_router.get(), kHistogramValue, kEventName,
                            profile1_, false, url);
 }
 
 TEST_F(EventRouterForwarderTest, BroadcastExtensionUI) {
   scoped_refptr<MockEventRouterForwarder> event_router(
       new MockEventRouterForwarder);
   GURL url;
-  EXPECT_CALL(*event_router.get(),
-              CallEventRouter(profile1_, kExt, kHistogramValue, kEventName,
-                              profile1_, url));
-  EXPECT_CALL(*event_router.get(),
-              CallEventRouter(profile2_, kExt, kHistogramValue, kEventName,
-                              profile2_, url));
+  EXPECT_CALL(*event_router, CallEventRouter(profile1_, kExt, kHistogramValue,
+                                             kEventName, profile1_, url));
+  EXPECT_CALL(*event_router, CallEventRouter(profile2_, kExt, kHistogramValue,
+                                             kEventName, profile2_, url));
   BroadcastEventToExtension(event_router.get(), kExt, kHistogramValue,
                             kEventName, url);
 }
 
 TEST_F(EventRouterForwarderTest, UnicastExtensionUIRestricted) {
   scoped_refptr<MockEventRouterForwarder> event_router(
       new MockEventRouterForwarder);
   using ::testing::_;
   GURL url;
-  EXPECT_CALL(*event_router.get(),
-              CallEventRouter(profile1_, kExt, kHistogramValue, kEventName,
-                              profile1_, url));
-  EXPECT_CALL(*event_router.get(), CallEventRouter(profile2_, _, _, _, _, _))
+  EXPECT_CALL(*event_router, CallEventRouter(profile1_, kExt, kHistogramValue,
+                                             kEventName, profile1_, url));
+  EXPECT_CALL(*event_router, CallEventRouter(profile2_, _, _, _, _, _))
       .Times(0);
   DispatchEventToExtension(event_router.get(), kExt, kHistogramValue,
                            kEventName, profile1_, true, url);
 }
 
 TEST_F(EventRouterForwarderTest, UnicastExtensionUIUnrestricted) {
   scoped_refptr<MockEventRouterForwarder> event_router(
       new MockEventRouterForwarder);
   using ::testing::_;
   GURL url;
-  EXPECT_CALL(
-      *event_router.get(),
-      CallEventRouter(profile1_, kExt, kHistogramValue, kEventName, NULL, url));
-  EXPECT_CALL(*event_router.get(), CallEventRouter(profile2_, _, _, _, _, _))
+  EXPECT_CALL(*event_router, CallEventRouter(profile1_, kExt, kHistogramValue,
+                                             kEventName, NULL, url));
+  EXPECT_CALL(*event_router, CallEventRouter(profile2_, _, _, _, _, _))
       .Times(0);
   DispatchEventToExtension(event_router.get(), kExt, kHistogramValue,
                            kEventName, profile1_, false, url);
 }
 
 }  // namespace extensions