[Extensions] Code Cleanup - Remove redundant smart-ptr get()s

chrome/browser/extensions/activity_log/counting_policy_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/activity_log/counting_policy.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <memory>
@@ skipping 165 matching lines @@
     ASSERT_EQ(2, static_cast<int>(i->size()));
   }
 
   static void RetrieveActions_FetchFilteredActions300(
       std::unique_ptr<std::vector<scoped_refptr<Action>>> i) {
     ASSERT_EQ(300, static_cast<int>(i->size()));
   }
 
   static void Arguments_Stripped(std::unique_ptr<Action::ActionVector> i) {
     scoped_refptr<Action> last = i->front();
-    CheckAction(*last.get(),
-                "odlameecjipmbmbejkplpemijjgpljce",
-                Action::ACTION_API_CALL,
-                "extension.connect",
-                "[\"hello\",\"world\"]",
-                "",
-                "",
-                "",
-                1);
+    CheckAction(*last, "odlameecjipmbmbejkplpemijjgpljce",
+                Action::ACTION_API_CALL, "extension.connect",
+                "[\"hello\",\"world\"]", "", "", "", 1);
   }
 
   static void Arguments_GetSinglesAction(
       std::unique_ptr<Action::ActionVector> actions) {
     ASSERT_EQ(1, static_cast<int>(actions->size()));
-    CheckAction(*actions->at(0).get(),
-                "punky",
-                Action::ACTION_DOM_ACCESS,
-                "lets",
-                "",
-                "http://www.google.com/",
-                "",
-                "",
-                1);
+    CheckAction(*actions->at(0), "punky", Action::ACTION_DOM_ACCESS, "lets", "",
+                "http://www.google.com/", "", "", 1);
   }
 
   static void Arguments_GetTodaysActions(
       std::unique_ptr<Action::ActionVector> actions) {
     ASSERT_EQ(3, static_cast<int>(actions->size()));
-    CheckAction(*actions->at(0).get(),
-                "punky",
-                Action::ACTION_API_CALL,
-                "brewster",
-                "",
-                "",
-                "",
-                "",
-                2);
-    CheckAction(*actions->at(1).get(),
-                "punky",
-                Action::ACTION_DOM_ACCESS,
-                "lets",
-                "",
-                "http://www.google.com/",
-                "",
-                "",
-                1);
-    CheckAction(*actions->at(2).get(),
-                "punky",
-                Action::ACTION_API_CALL,
-                "extension.sendMessage",
-                "[\"not\",\"stripped\"]",
-                "",
-                "",
-                "",
+    CheckAction(*actions->at(0), "punky", Action::ACTION_API_CALL, "brewster",
+                "", "", "", "", 2);
+    CheckAction(*actions->at(1), "punky", Action::ACTION_DOM_ACCESS, "lets", "",
+                "http://www.google.com/", "", "", 1);
+    CheckAction(*actions->at(2), "punky", Action::ACTION_API_CALL,
+                "extension.sendMessage", "[\"not\",\"stripped\"]", "", "", "",
                 1);
   }
 
   static void Arguments_GetOlderActions(
       std::unique_ptr<Action::ActionVector> actions) {
     ASSERT_EQ(2, static_cast<int>(actions->size()));
-    CheckAction(*actions->at(0).get(),
-                "punky",
-                Action::ACTION_DOM_ACCESS,
-                "lets",
-                "",
-                "http://www.google.com/",
-                "",
-                "",
-                1);
-    CheckAction(*actions->at(1).get(),
-                "punky",
-                Action::ACTION_API_CALL,
-                "brewster",
-                "",
-                "",
-                "",
-                "",
-                1);
+    CheckAction(*actions->at(0), "punky", Action::ACTION_DOM_ACCESS, "lets", "",
+                "http://www.google.com/", "", "", 1);
+    CheckAction(*actions->at(1), "punky", Action::ACTION_API_CALL, "brewster",
+                "", "", "", "", 1);
   }
 
   static void Arguments_CheckMergeCount(
       int count,
       std::unique_ptr<Action::ActionVector> actions) {
     if (count > 0) {
       ASSERT_EQ(1u, actions->size());
-      CheckAction(*actions->at(0).get(),
-                  "punky",
-                  Action::ACTION_API_CALL,
-                  "brewster",
-                  "",
-                  "",
-                  "",
-                  "",
-                  count);
+      CheckAction(*actions->at(0), "punky", Action::ACTION_API_CALL, "brewster",
+                  "", "", "", "", count);
     } else {
       ASSERT_EQ(0u, actions->size());
     }
   }
 
   static void Arguments_CheckMergeCountAndTime(
       int count,
       const base::Time& time,
       std::unique_ptr<Action::ActionVector> actions) {
     if (count > 0) {
       ASSERT_EQ(1u, actions->size());
-      CheckAction(*actions->at(0).get(),
-                  "punky",
-                  Action::ACTION_API_CALL,
-                  "brewster",
-                  "",
-                  "",
-                  "",
-                  "",
-                  count);
+      CheckAction(*actions->at(0), "punky", Action::ACTION_API_CALL, "brewster",
+                  "", "", "", "", count);
       ASSERT_EQ(time, actions->at(0)->time());
     } else {
       ASSERT_EQ(0u, actions->size());
     }
   }
 
   static void AllURLsRemoved(std::unique_ptr<Action::ActionVector> actions) {
     ASSERT_EQ(2, static_cast<int>(actions->size()));
-    CheckAction(*actions->at(0).get(),
-                "punky",
-                Action::ACTION_DOM_ACCESS,
-                "lets",
-                "",
-                "",
-                "",
-                "",
-                1);
-    CheckAction(*actions->at(1).get(),
-                "punky",
-                Action::ACTION_DOM_ACCESS,
-                "lets",
-                "",
-                "",
-                "",
-                "",
-                1);
+    CheckAction(*actions->at(0), "punky", Action::ACTION_DOM_ACCESS, "lets", "",
+                "", "", "", 1);
+    CheckAction(*actions->at(1), "punky", Action::ACTION_DOM_ACCESS, "lets", "",
+                "", "", "", 1);
   }
 
   static void SomeURLsRemoved(std::unique_ptr<Action::ActionVector> actions) {
     // These will be in the vector in reverse time order.
     ASSERT_EQ(5, static_cast<int>(actions->size()));
-    CheckAction(*actions->at(0).get(),
-                "punky",
-                Action::ACTION_DOM_ACCESS,
-                "lets",
-                "",
-                "http://www.google.com/",
-                "Google",
-                "http://www.args-url.com/",
+    CheckAction(*actions->at(0), "punky", Action::ACTION_DOM_ACCESS, "lets", "",
+                "http://www.google.com/", "Google", "http://www.args-url.com/",
                 1);
-    CheckAction(*actions->at(1).get(),
-                "punky",
-                Action::ACTION_DOM_ACCESS,
-                "lets",
-                "",
-                "http://www.google.com/",
-                "Google",
-                "",
-                1);
-    CheckAction(*actions->at(2).get(),
-                "punky",
-                Action::ACTION_DOM_ACCESS,
-                "lets",
-                "",
-                "",
-                "",
-                "",
-                1);
-    CheckAction(*actions->at(3).get(),
-                "punky",
-                Action::ACTION_DOM_ACCESS,
-                "lets",
-                "",
-                "",
-                "",
-                "http://www.google.com/",
-                1);
-    CheckAction(*actions->at(4).get(),
-                "punky",
-                Action::ACTION_DOM_ACCESS,
-                "lets",
-                "",
-                "",
-                "",
-                "",
-                1);
+    CheckAction(*actions->at(1), "punky", Action::ACTION_DOM_ACCESS, "lets", "",
+                "http://www.google.com/", "Google", "", 1);
+    CheckAction(*actions->at(2), "punky", Action::ACTION_DOM_ACCESS, "lets", "",
+                "", "", "", 1);
+    CheckAction(*actions->at(3), "punky", Action::ACTION_DOM_ACCESS, "lets", "",
+                "", "", "http://www.google.com/", 1);
+    CheckAction(*actions->at(4), "punky", Action::ACTION_DOM_ACCESS, "lets", "",
+                "", "", "", 1);
   }
 
   static void CheckDuplicates(std::unique_ptr<Action::ActionVector> actions) {
     ASSERT_EQ(2u, actions->size());
     int total_count = 0;
     for (size_t i = 0; i < actions->size(); i++) {
       total_count += actions->at(i)->count();
     }
     ASSERT_EQ(3, total_count);
   }
@@ skipping 73 matching lines @@
     policy->DeleteDatabase();
   }
 
   static void AllActionsDeleted(std::unique_ptr<Action::ActionVector> actions) {
     ASSERT_EQ(0, static_cast<int>(actions->size()));
   }
 
   static void NoActionsDeleted(std::unique_ptr<Action::ActionVector> actions) {
     // These will be in the vector in reverse time order.
     ASSERT_EQ(2, static_cast<int>(actions->size()));
-    CheckAction(*actions->at(0).get(),
-                "punky2",
-                Action::ACTION_API_CALL,
-                "lets2",
-                "",
-                "http://www.google2.com/",
-                "Google2",
-                "http://www.args-url2.com/",
-                2);
+    CheckAction(*actions->at(0), "punky2", Action::ACTION_API_CALL, "lets2", "",
+                "http://www.google2.com/", "Google2",
+                "http://www.args-url2.com/", 2);
     ASSERT_EQ(2, actions->at(0)->action_id());
-    CheckAction(*actions->at(1).get(),
-                "punky1",
-                Action::ACTION_DOM_ACCESS,
-                "lets1",
-                "",
-                "http://www.google1.com/",
-                "Google1",
-                "http://www.args-url1.com/",
-                2);
+    CheckAction(*actions->at(1), "punky1", Action::ACTION_DOM_ACCESS, "lets1",
+                "", "http://www.google1.com/", "Google1",
+                "http://www.args-url1.com/", 2);
     ASSERT_EQ(1, actions->at(1)->action_id());
   }
 
   static void Action1Deleted(std::unique_ptr<Action::ActionVector> actions) {
     // These will be in the vector in reverse time order.
     ASSERT_EQ(1, static_cast<int>(actions->size()));
-    CheckAction(*actions->at(0).get(),
-                "punky2",
-                Action::ACTION_API_CALL,
-                "lets2",
-                "",
-                "http://www.google2.com/",
-                "Google2",
-                "http://www.args-url2.com/",
-                2);
+    CheckAction(*actions->at(0), "punky2", Action::ACTION_API_CALL, "lets2", "",
+                "http://www.google2.com/", "Google2",
+                "http://www.args-url2.com/", 2);
     ASSERT_EQ(2, actions->at(0)->action_id());
   }
 
   static void Action2Deleted(std::unique_ptr<Action::ActionVector> actions) {
     // These will be in the vector in reverse time order.
     ASSERT_EQ(1, static_cast<int>(actions->size()));
-    CheckAction(*actions->at(0).get(),
-                "punky1",
-                Action::ACTION_DOM_ACCESS,
-                "lets1",
-                "",
-                "http://www.google1.com/",
-                "Google1",
-                "http://www.args-url1.com/",
-                2);
+    CheckAction(*actions->at(0), "punky1", Action::ACTION_DOM_ACCESS, "lets1",
+                "", "http://www.google1.com/", "Google1",
+                "http://www.args-url1.com/", 2);
     ASSERT_EQ(1, actions->at(0)->action_id());
   }
 
  protected:
   ExtensionService* extension_service_;
   std::unique_ptr<TestingProfile> profile_;
   content::TestBrowserThreadBundle thread_bundle_;
 
 #if defined OS_CHROMEOS
   chromeos::ScopedTestDeviceSettingsService test_device_settings_service_;
@@ skipping 884 matching lines @@
 
   action_ids.push_back(2);
   CheckRemoveActions(
       policy, action_ids, base::Bind(&CountingPolicyTest::Action2Deleted));
   action_ids.clear();
 
   policy->Close();
 }
 
 }  // namespace extensions