[Extensions] DCHECK that ExtensionFunctions respond (and only once)

[Extensions] DCHECK that ExtensionFunctions respond (and only once)

If an ExtensionFunction never responds, it means that there's a leak on
the renderer side where we never clean up after the request, not to
mention the fact that the extension calling the API is left hanging.
DCHECK() that every extension function responds. Conversely, if the
function responds twice, we send multiple IPCs and have to reserialize
all the response values, in addition to the fact that it meant the
function likely responded before work was done or with an incomplete
response.

Most of this involves changes to test or private code, but there are a
few places where this affects real APIs.

One significant change apart from general cleanup is to add a boolean
to the NOTIFICATION_EXTENSION_TEST_MESSAGE details allowing the
receiver to indicate whether or not they will respond. If no receiver
indicates they will respond, the function returns immediately.

BUG=616593
TBR=stevenjb@chromium.org (c/b/chromeos, c/b/ui/webui/chromeos)
TBR=atwilson@chromium.org (c/b/policy)
TBR=raymes@chromium.org (c/t/ppapi)

Committed: https://crrev.com/7d873db838bd65a60ac84a236a4845f18d0dc895
Cr-Commit-Position: refs/heads/master@{#397594}

[Devlin, 2016-06-01 20:51:01]

Patchset #1 (id:1) has been deleted

[Devlin, 2016-06-01 20:51:54]

Patchset #1 (id:20001) has been deleted

[Devlin, 2016-06-01 20:52:02]

Patchset #1 (id:40001) has been deleted

[Devlin, 2016-06-01 20:56:51]

Patchset #1 (id:60001) has been deleted

[Devlin, 2016-06-01 20:56:58]

Patchset #1 (id:80001) has been deleted

[Devlin, 2016-06-01 20:57:07]

Patchset #1 (id:100001) has been deleted

[Devlin, 2016-06-01 20:57:17]

Patchset #1 (id:120001) has been deleted

[Devlin, 2016-06-01 21:01:39]

Patchset #1 (id:140001) has been deleted

[Devlin, 2016-06-01 21:02:23]

Patchset #1 (id:160001) has been deleted

[Devlin, 2016-06-01 21:02:51]

Patchset #1 (id:180001) has been deleted

[Devlin, 2016-06-01 21:06:39]

Description was changed from

==========
maybesomething

BUG=
==========

to

==========
[Extensions] DCHECK that ExtensionFunctions respond (and only once)

If an ExtensionFunction never responds, it means that there's a leak on
the renderer side where we never clean up after the request, not to
mention the fact that the extension calling the API is left hanging.
DCHECK() that every extension function responds. Conversely, if the
function responds twice, we send multiple IPCs and have to reserialize
all the response values, in addition to the fact that it meant the
function likely responded before work was done or with an incomplete
response.

Most of this involves changes to test or private code, but there are a
few places where this affects real APIs.

One significant change apart from general cleanup is to add a boolean
to the NOTIFICATION_EXTENSION_TEST_MESSAGE details allowing the
receiver to indicate whether or not they will respond. If no receiver
indicates they will respond, the function returns immediately.

BUG=616593
==========

[Devlin, 2016-06-01 21:08:06]

rdevlin.cronin@chromium.org changed reviewers:
+ asargent@chromium.org

[Devlin, 2016-06-01 21:08:07]

Another one for you, Antony.  Sorry, I know it looks (and kind of is) painful. 
On the upside, this fixes a number of bugs we never knew we had, and hopefully
does a halfway decent job of preventing more from cropping up.

[asargent_no_longer_on_chrome, 2016-06-02 19:48:05]

lgtm

[Devlin, 2016-06-02 21:32:05]

Description was changed from

==========
[Extensions] DCHECK that ExtensionFunctions respond (and only once)

If an ExtensionFunction never responds, it means that there's a leak on
the renderer side where we never clean up after the request, not to
mention the fact that the extension calling the API is left hanging.
DCHECK() that every extension function responds. Conversely, if the
function responds twice, we send multiple IPCs and have to reserialize
all the response values, in addition to the fact that it meant the
function likely responded before work was done or with an incomplete
response.

Most of this involves changes to test or private code, but there are a
few places where this affects real APIs.

One significant change apart from general cleanup is to add a boolean
to the NOTIFICATION_EXTENSION_TEST_MESSAGE details allowing the
receiver to indicate whether or not they will respond. If no receiver
indicates they will respond, the function returns immediately.

BUG=616593
==========

to

==========
[Extensions] DCHECK that ExtensionFunctions respond (and only once)

If an ExtensionFunction never responds, it means that there's a leak on
the renderer side where we never clean up after the request, not to
mention the fact that the extension calling the API is left hanging.
DCHECK() that every extension function responds. Conversely, if the
function responds twice, we send multiple IPCs and have to reserialize
all the response values, in addition to the fact that it meant the
function likely responded before work was done or with an incomplete
response.

Most of this involves changes to test or private code, but there are a
few places where this affects real APIs.

One significant change apart from general cleanup is to add a boolean
to the NOTIFICATION_EXTENSION_TEST_MESSAGE details allowing the
receiver to indicate whether or not they will respond. If no receiver
indicates they will respond, the function returns immediately.

BUG=616593
TBR=stevenjb@chromium.org (c/b/chromeos, c/b/ui/webui/chromeos)
TBR=atwilson@chromium.org (c/b/policy)
TBR=raymes@chromium.org (c/t/ppapi)
==========

[Devlin, 2016-06-02 21:32:15]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2016-06-02 21:33:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2017113002/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2017113002/200001

[commit-bot: I haz the power, 2016-06-03 00:53:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-03 00:53:08]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Devlin, 2016-06-03 00:57:41]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2016-06-03 00:58:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2017113002/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2017113002/200001

[commit-bot: I haz the power, 2016-06-03 02:41:40]

Description was changed from

==========
[Extensions] DCHECK that ExtensionFunctions respond (and only once)

If an ExtensionFunction never responds, it means that there's a leak on
the renderer side where we never clean up after the request, not to
mention the fact that the extension calling the API is left hanging.
DCHECK() that every extension function responds. Conversely, if the
function responds twice, we send multiple IPCs and have to reserialize
all the response values, in addition to the fact that it meant the
function likely responded before work was done or with an incomplete
response.

Most of this involves changes to test or private code, but there are a
few places where this affects real APIs.

One significant change apart from general cleanup is to add a boolean
to the NOTIFICATION_EXTENSION_TEST_MESSAGE details allowing the
receiver to indicate whether or not they will respond. If no receiver
indicates they will respond, the function returns immediately.

BUG=616593
TBR=stevenjb@chromium.org (c/b/chromeos, c/b/ui/webui/chromeos)
TBR=atwilson@chromium.org (c/b/policy)
TBR=raymes@chromium.org (c/t/ppapi)
==========

to

==========
[Extensions] DCHECK that ExtensionFunctions respond (and only once)

If an ExtensionFunction never responds, it means that there's a leak on
the renderer side where we never clean up after the request, not to
mention the fact that the extension calling the API is left hanging.
DCHECK() that every extension function responds. Conversely, if the
function responds twice, we send multiple IPCs and have to reserialize
all the response values, in addition to the fact that it meant the
function likely responded before work was done or with an incomplete
response.

Most of this involves changes to test or private code, but there are a
few places where this affects real APIs.

One significant change apart from general cleanup is to add a boolean
to the NOTIFICATION_EXTENSION_TEST_MESSAGE details allowing the
receiver to indicate whether or not they will respond. If no receiver
indicates they will respond, the function returns immediately.

BUG=616593
TBR=stevenjb@chromium.org (c/b/chromeos, c/b/ui/webui/chromeos)
TBR=atwilson@chromium.org (c/b/policy)
TBR=raymes@chromium.org (c/t/ppapi)
==========

[commit-bot: I haz the power, 2016-06-03 02:41:42]

Committed patchset #1 (id:200001)

[commit-bot: I haz the power, 2016-06-03 02:45:38]

Description was changed from

==========
[Extensions] DCHECK that ExtensionFunctions respond (and only once)

If an ExtensionFunction never responds, it means that there's a leak on
the renderer side where we never clean up after the request, not to
mention the fact that the extension calling the API is left hanging.
DCHECK() that every extension function responds. Conversely, if the
function responds twice, we send multiple IPCs and have to reserialize
all the response values, in addition to the fact that it meant the
function likely responded before work was done or with an incomplete
response.

Most of this involves changes to test or private code, but there are a
few places where this affects real APIs.

One significant change apart from general cleanup is to add a boolean
to the NOTIFICATION_EXTENSION_TEST_MESSAGE details allowing the
receiver to indicate whether or not they will respond. If no receiver
indicates they will respond, the function returns immediately.

BUG=616593
TBR=stevenjb@chromium.org (c/b/chromeos, c/b/ui/webui/chromeos)
TBR=atwilson@chromium.org (c/b/policy)
TBR=raymes@chromium.org (c/t/ppapi)
==========

to

==========
[Extensions] DCHECK that ExtensionFunctions respond (and only once)

If an ExtensionFunction never responds, it means that there's a leak on
the renderer side where we never clean up after the request, not to
mention the fact that the extension calling the API is left hanging.
DCHECK() that every extension function responds. Conversely, if the
function responds twice, we send multiple IPCs and have to reserialize
all the response values, in addition to the fact that it meant the
function likely responded before work was done or with an incomplete
response.

Most of this involves changes to test or private code, but there are a
few places where this affects real APIs.

One significant change apart from general cleanup is to add a boolean
to the NOTIFICATION_EXTENSION_TEST_MESSAGE details allowing the
receiver to indicate whether or not they will respond. If no receiver
indicates they will respond, the function returns immediately.

BUG=616593
TBR=stevenjb@chromium.org (c/b/chromeos, c/b/ui/webui/chromeos)
TBR=atwilson@chromium.org (c/b/policy)
TBR=raymes@chromium.org (c/t/ppapi)

Committed: https://crrev.com/7d873db838bd65a60ac84a236a4845f18d0dc895
Cr-Commit-Position: refs/heads/master@{#397594}
==========

[commit-bot: I haz the power, 2016-06-03 02:45:40]

Patchset 1 (id:??) landed as
https://crrev.com/7d873db838bd65a60ac84a236a4845f18d0dc895
Cr-Commit-Position: refs/heads/master@{#397594}