[Extensions] DCHECK that ExtensionFunctions respond (and only once)

extensions/browser/extension_function_dispatcher.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/extension_function_dispatcher.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/json/json_string_value_serializer.h"
@@ skipping 356 matching lines @@
     function->set_include_incognito(
         extension_info_map->IsIncognitoEnabled(extension->id()));
   }
 
   if (!CheckPermissions(function.get(), params, callback))
     return;
 
   if (!extension) {
     // Skip all of the UMA, quota, event page, activity logging stuff if there
     // isn't an extension, e.g. if the function call was from WebUI.
-    function->Run()->Execute();
+    function->RunWithValidation()->Execute();
     return;
   }
 
   QuotaService* quota = extension_info_map->GetQuotaService();
   std::string violation_error = quota->Assess(extension->id(),
                                               function.get(),
                                               &params.arguments,
                                               base::TimeTicks::Now());
   if (violation_error.empty()) {
     std::unique_ptr<base::ListValue> args(params.arguments.DeepCopy());
     NotifyApiFunctionCalled(extension->id(), params.name, std::move(args),
                             static_cast<content::BrowserContext*>(profile_id));
     UMA_HISTOGRAM_SPARSE_SLOWLY("Extensions.FunctionCalls",
                                 function->histogram_value());
     tracked_objects::ScopedProfile scoped_profile(
         FROM_HERE_WITH_EXPLICIT_FUNCTION(function->name()),
         tracked_objects::ScopedProfile::ENABLED);
     base::ElapsedTimer timer;
-    function->Run()->Execute();
+    function->RunWithValidation()->Execute();
     // TODO(devlin): Once we have a baseline metric for how long functions take,
     // we can create a handful of buckets and record the function name so that
     // we can find what the fastest/slowest are.
     // Note: Many functions execute finish asynchronously, so this time is not
     // always a representation of total time taken. See also
     // Extensions.Functions.TotalExecutionTime.
     UMA_HISTOGRAM_TIMES("Extensions.Functions.SynchronousExecutionTime",
                         timer.Elapsed());
   } else {
     function->OnQuotaExceeded(violation_error);
@@ skipping 92 matching lines @@
           extension, browser_context_)) {
     function->set_include_incognito(true);
   }
 
   if (!CheckPermissions(function.get(), params, callback))
     return;
 
   if (!extension) {
     // Skip all of the UMA, quota, event page, activity logging stuff if there
     // isn't an extension, e.g. if the function call was from WebUI.
-    function->Run()->Execute();
+    function->RunWithValidation()->Execute();
     return;
   }
 
   // Fetch the ProcessManager before |this| is possibly invalidated.
   ProcessManager* process_manager = ProcessManager::Get(browser_context_);
 
   ExtensionSystem* extension_system = ExtensionSystem::Get(browser_context_);
   QuotaService* quota = extension_system->quota_service();
   std::string violation_error = quota->Assess(extension->id(),
                                               function.get(),
                                               &params.arguments,
                                               base::TimeTicks::Now());
 
   if (violation_error.empty()) {
     std::unique_ptr<base::ListValue> args(params.arguments.DeepCopy());
 
     // See crbug.com/39178.
     ExtensionsBrowserClient::Get()->PermitExternalProtocolHandler();
     NotifyApiFunctionCalled(extension->id(), params.name, std::move(args),
                             browser_context_);
     UMA_HISTOGRAM_SPARSE_SLOWLY("Extensions.FunctionCalls",
                                 function->histogram_value());
     tracked_objects::ScopedProfile scoped_profile(
         FROM_HERE_WITH_EXPLICIT_FUNCTION(function->name()),
         tracked_objects::ScopedProfile::ENABLED);
     base::ElapsedTimer timer;
-    function->Run()->Execute();
+    function->RunWithValidation()->Execute();
     // TODO(devlin): Once we have a baseline metric for how long functions take,
     // we can create a handful of buckets and record the function name so that
     // we can find what the fastest/slowest are.
     // Note: Many functions execute finish asynchronously, so this time is not
     // always a representation of total time taken. See also
     // Extensions.Functions.TotalExecutionTime.
     UMA_HISTOGRAM_TIMES("Extensions.Functions.SynchronousExecutionTime",
                         timer.Elapsed());
   } else {
     function->OnQuotaExceeded(violation_error);
@@ skipping 104 matching lines @@
 // static
 void ExtensionFunctionDispatcher::SendAccessDenied(
     const ExtensionFunction::ResponseCallback& callback,
     functions::HistogramValue histogram_value) {
   base::ListValue empty_list;
   callback.Run(ExtensionFunction::FAILED, empty_list,
                "Access to extension API denied.", histogram_value);
 }
 
 }  // namespace extensions