Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(777)

Unified Diff: chrome/browser/extensions/api/activity_log_private/activity_log_private_api.h

Issue 2017113002: [Extensions] DCHECK that ExtensionFunctions respond (and only once) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/activity_log_private/activity_log_private_api.h
diff --git a/chrome/browser/extensions/api/activity_log_private/activity_log_private_api.h b/chrome/browser/extensions/api/activity_log_private/activity_log_private_api.h
index d9591288879ac21022e46ee9f512672ac6204d49..25467ff882cad6d3fca04885d2b53bc40a3010b6 100644
--- a/chrome/browser/extensions/api/activity_log_private/activity_log_private_api.h
+++ b/chrome/browser/extensions/api/activity_log_private/activity_log_private_api.h
@@ -81,7 +81,7 @@ class ActivityLogPrivateGetExtensionActivitiesFunction
// The implementation of activityLogPrivate.deleteActivities
class ActivityLogPrivateDeleteActivitiesFunction
- : public ChromeAsyncExtensionFunction {
+ : public UIThreadExtensionFunction {
public:
DECLARE_EXTENSION_FUNCTION("activityLogPrivate.deleteActivities",
ACTIVITYLOGPRIVATE_DELETEACTIVITIES)
@@ -90,12 +90,12 @@ class ActivityLogPrivateDeleteActivitiesFunction
~ActivityLogPrivateDeleteActivitiesFunction() override {}
// ExtensionFunction:
- bool RunAsync() override;
+ ResponseAction Run() override;
};
// The implementation of activityLogPrivate.deleteDatabase
class ActivityLogPrivateDeleteDatabaseFunction
- : public ChromeAsyncExtensionFunction {
+ : public UIThreadExtensionFunction {
public:
DECLARE_EXTENSION_FUNCTION("activityLogPrivate.deleteDatabase",
ACTIVITYLOGPRIVATE_DELETEDATABASE)
@@ -104,12 +104,11 @@ class ActivityLogPrivateDeleteDatabaseFunction
~ActivityLogPrivateDeleteDatabaseFunction() override {}
// ExtensionFunction:
- bool RunAsync() override;
+ ResponseAction Run() override;
};
// The implementation of activityLogPrivate.deleteUrls
-class ActivityLogPrivateDeleteUrlsFunction
- : public ChromeAsyncExtensionFunction {
+class ActivityLogPrivateDeleteUrlsFunction : public UIThreadExtensionFunction {
public:
DECLARE_EXTENSION_FUNCTION("activityLogPrivate.deleteUrls",
ACTIVITYLOGPRIVATE_DELETEURLS)
@@ -118,7 +117,7 @@ class ActivityLogPrivateDeleteUrlsFunction
~ActivityLogPrivateDeleteUrlsFunction() override {}
// ExtensionFunction:
- bool RunAsync() override;
+ ResponseAction Run() override;
};
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698