chrome/browser/extensions/api/screenlock_private/screenlock_private_apitest.cc - Issue 2017113002: [Extensions] DCHECK that ExtensionFunctions respond (and only once)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/screenlock_private/screenlock_private_apitest.cc

Issue 2017113002: [Extensions] DCHECK that ExtensionFunctions respond (and only once) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc ('k') | chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/screenlock_private/screenlock_private_apitest.cc

diff --git a/chrome/browser/extensions/api/screenlock_private/screenlock_private_apitest.cc b/chrome/browser/extensions/api/screenlock_private/screenlock_private_apitest.cc

index 4bcd437789a6c358d3f1a6377fbb47295260f319..d16751b288ca3ab33aa2bf2820c9696062b0f13d 100644

--- a/chrome/browser/extensions/api/screenlock_private/screenlock_private_apitest.cc

+++ b/chrome/browser/extensions/api/screenlock_private/screenlock_private_apitest.cc

@@ -80,8 +80,9 @@ class ScreenlockPrivateApiTest : public ExtensionApiTest,

void Observe(int type,

const content::NotificationSource& source,

const content::NotificationDetails& details) override {

- const std::string& content = *content::Details<std::string>(details).ptr();

- if (content == kAttemptClickAuthMessage) {

+ const std::string& message =

+ content::Details<std::pair<std::string, bool*>>(details).ptr()->first;

+ if (message == kAttemptClickAuthMessage) {

proximity_auth::ScreenlockBridge::Get()->lock_handler()->SetAuthType(

test_account_id_,

proximity_auth::ScreenlockBridge::LockHandler::USER_CLICK,