chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.h - Issue 2017113002: [Extensions] DCHECK that ExtensionFunctions respond (and only once)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.h

Issue 2017113002: [Extensions] DCHECK that ExtensionFunctions respond (and only once) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc ('k') | chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.h

diff --git a/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.h b/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.h

index ba4b298a2f29896696cb3fd32d7b60e470a01172..932a1b82220131ee8d04d4dcf788f7d9eb9358e1 100644

--- a/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.h

+++ b/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.h

@@ -197,7 +197,8 @@ class BookmarkManagerPrivateSortChildrenFunction

bool RunOnReady() override;

};

-class BookmarkManagerPrivateGetStringsFunction : public AsyncExtensionFunction {

+class BookmarkManagerPrivateGetStringsFunction

+ : public UIThreadExtensionFunction {

public:

DECLARE_EXTENSION_FUNCTION("bookmarkManagerPrivate.getStrings",

BOOKMARKMANAGERPRIVATE_GETSTRINGS)

@@ -205,8 +206,8 @@ class BookmarkManagerPrivateGetStringsFunction : public AsyncExtensionFunction {

protected:

~BookmarkManagerPrivateGetStringsFunction() override {}

- // ExtensionFunction:

- bool RunAsync() override;

+ // UIThreadExtensionFunction:

+ ResponseAction Run() override;

};

class BookmarkManagerPrivateStartDragFunction