chrome/browser/chromeos/extensions/echo_private_api.cc - Issue 2017113002: [Extensions] DCHECK that ExtensionFunctions respond (and only once)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/echo_private_api.cc

Issue 2017113002: [Extensions] DCHECK that ExtensionFunctions respond (and only once) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/apps/app_window_interactive_uitest.cc ('k') | chrome/browser/chromeos/extensions/input_method_apitest_chromeos.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/echo_private_api.cc

diff --git a/chrome/browser/chromeos/extensions/echo_private_api.cc b/chrome/browser/chromeos/extensions/echo_private_api.cc

index 728b77a974bdfa94f5e72c1996e365467075b3c0..7af780ebfd920c57bfeb849f41065eccc450333b 100644

--- a/chrome/browser/chromeos/extensions/echo_private_api.cc

+++ b/chrome/browser/chromeos/extensions/echo_private_api.cc

@@ -78,7 +78,6 @@ void EchoPrivateGetRegistrationCodeFunction::GetRegistrationCode(

}

results_ = echo_api::GetRegistrationCode::Results::Create(result);

- SendResponse(true);

}

bool EchoPrivateGetRegistrationCodeFunction::RunSync() {