Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Side by Side Diff: chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.h

Issue 2017113002: [Extensions] DCHECK that ExtensionFunctions respond (and only once) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_API_BOOKMARK_MANAGER_PRIVATE_BOOKMARK_MANAGER_ PRIVATE_API_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_API_BOOKMARK_MANAGER_PRIVATE_BOOKMARK_MANAGER_ PRIVATE_API_H_
6 #define CHROME_BROWSER_EXTENSIONS_API_BOOKMARK_MANAGER_PRIVATE_BOOKMARK_MANAGER_ PRIVATE_API_H_ 6 #define CHROME_BROWSER_EXTENSIONS_API_BOOKMARK_MANAGER_PRIVATE_BOOKMARK_MANAGER_ PRIVATE_API_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 179 matching lines...) Expand 10 before | Expand all | Expand 10 after
190 DECLARE_EXTENSION_FUNCTION("bookmarkManagerPrivate.sortChildren", 190 DECLARE_EXTENSION_FUNCTION("bookmarkManagerPrivate.sortChildren",
191 BOOKMARKMANAGERPRIVATE_SORTCHILDREN) 191 BOOKMARKMANAGERPRIVATE_SORTCHILDREN)
192 192
193 protected: 193 protected:
194 ~BookmarkManagerPrivateSortChildrenFunction() override {} 194 ~BookmarkManagerPrivateSortChildrenFunction() override {}
195 195
196 // ExtensionFunction: 196 // ExtensionFunction:
197 bool RunOnReady() override; 197 bool RunOnReady() override;
198 }; 198 };
199 199
200 class BookmarkManagerPrivateGetStringsFunction : public AsyncExtensionFunction { 200 class BookmarkManagerPrivateGetStringsFunction
201 : public UIThreadExtensionFunction {
201 public: 202 public:
202 DECLARE_EXTENSION_FUNCTION("bookmarkManagerPrivate.getStrings", 203 DECLARE_EXTENSION_FUNCTION("bookmarkManagerPrivate.getStrings",
203 BOOKMARKMANAGERPRIVATE_GETSTRINGS) 204 BOOKMARKMANAGERPRIVATE_GETSTRINGS)
204 205
205 protected: 206 protected:
206 ~BookmarkManagerPrivateGetStringsFunction() override {} 207 ~BookmarkManagerPrivateGetStringsFunction() override {}
207 208
208 // ExtensionFunction: 209 // UIThreadExtensionFunction:
209 bool RunAsync() override; 210 ResponseAction Run() override;
210 }; 211 };
211 212
212 class BookmarkManagerPrivateStartDragFunction 213 class BookmarkManagerPrivateStartDragFunction
213 : public extensions::BookmarksFunction { 214 : public extensions::BookmarksFunction {
214 public: 215 public:
215 DECLARE_EXTENSION_FUNCTION("bookmarkManagerPrivate.startDrag", 216 DECLARE_EXTENSION_FUNCTION("bookmarkManagerPrivate.startDrag",
216 BOOKMARKMANAGERPRIVATE_STARTDRAG) 217 BOOKMARKMANAGERPRIVATE_STARTDRAG)
217 218
218 protected: 219 protected:
219 ~BookmarkManagerPrivateStartDragFunction() override {} 220 ~BookmarkManagerPrivateStartDragFunction() override {}
(...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after
400 protected: 401 protected:
401 ~BookmarkManagerPrivateGetRedoInfoFunction() override {} 402 ~BookmarkManagerPrivateGetRedoInfoFunction() override {}
402 403
403 // ExtensionFunction: 404 // ExtensionFunction:
404 bool RunOnReady() override; 405 bool RunOnReady() override;
405 }; 406 };
406 407
407 } // namespace extensions 408 } // namespace extensions
408 409
409 #endif // CHROME_BROWSER_EXTENSIONS_API_BOOKMARK_MANAGER_PRIVATE_BOOKMARK_MANAG ER_PRIVATE_API_H_ 410 #endif // CHROME_BROWSER_EXTENSIONS_API_BOOKMARK_MANAGER_PRIVATE_BOOKMARK_MANAG ER_PRIVATE_API_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698