Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3570)

Unified Diff: extensions/browser/api/guest_view/app_view/app_view_guest_internal_api.h

Issue 2017113002: [Extensions] DCHECK that ExtensionFunctions respond (and only once) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/guest_view/app_view/app_view_guest_internal_api.h
diff --git a/extensions/browser/api/guest_view/app_view/app_view_guest_internal_api.h b/extensions/browser/api/guest_view/app_view/app_view_guest_internal_api.h
index e9e252bb2d9e9cd6055f1094f9c8e11d7073e42f..0bcb7d85cf57f70666817e4d871342a8ff386b68 100644
--- a/extensions/browser/api/guest_view/app_view/app_view_guest_internal_api.h
+++ b/extensions/browser/api/guest_view/app_view/app_view_guest_internal_api.h
@@ -10,7 +10,8 @@
namespace extensions {
-class AppViewGuestInternalAttachFrameFunction : public AsyncExtensionFunction {
+class AppViewGuestInternalAttachFrameFunction
+ : public UIThreadExtensionFunction {
public:
DECLARE_EXTENSION_FUNCTION("appViewGuestInternal.attachFrame",
APPVIEWINTERNAL_ATTACHFRAME);
@@ -18,13 +19,14 @@ class AppViewGuestInternalAttachFrameFunction : public AsyncExtensionFunction {
protected:
~AppViewGuestInternalAttachFrameFunction() override {}
- bool RunAsync() final;
+ ResponseAction Run() final;
private:
DISALLOW_COPY_AND_ASSIGN(AppViewGuestInternalAttachFrameFunction);
};
-class AppViewGuestInternalDenyRequestFunction : public AsyncExtensionFunction {
+class AppViewGuestInternalDenyRequestFunction
+ : public UIThreadExtensionFunction {
public:
DECLARE_EXTENSION_FUNCTION("appViewGuestInternal.denyRequest",
APPVIEWINTERNAL_DENYREQUEST);
@@ -32,7 +34,7 @@ class AppViewGuestInternalDenyRequestFunction : public AsyncExtensionFunction {
protected:
~AppViewGuestInternalDenyRequestFunction() override {}
- bool RunAsync() final;
+ ResponseAction Run() final;
private:
DISALLOW_COPY_AND_ASSIGN(AppViewGuestInternalDenyRequestFunction);

Powered by Google App Engine
This is Rietveld 408576698