chrome/browser/extensions/api/downloads/downloads_api.cc - Issue 2017113002: [Extensions] DCHECK that ExtensionFunctions respond (and only once)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/downloads/downloads_api.cc

Issue 2017113002: [Extensions] DCHECK that ExtensionFunctions respond (and only once) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/declarative_content/set_icon_apitest.cc ('k') | chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/downloads/downloads_api.cc

diff --git a/chrome/browser/extensions/api/downloads/downloads_api.cc b/chrome/browser/extensions/api/downloads/downloads_api.cc

index 5c10000284ab67b7a89e65b18a752bbd322ec1aa..bbbb6519af6b379959638ad39cede31bcb567e27 100644

--- a/chrome/browser/extensions/api/downloads/downloads_api.cc

+++ b/chrome/browser/extensions/api/downloads/downloads_api.cc

@@ -1271,7 +1271,7 @@ void DownloadsAcceptDangerFunction::PromptOrWait(int download_id, int retries) {

return;

}

error_ = errors::kInvisibleContext;

- SendResponse(error_.empty());

+ SendResponse(false);

return;

}

RecordApiFunctions(DOWNLOADS_FUNCTION_ACCEPT_DANGER);

@@ -1286,7 +1286,7 @@ void DownloadsAcceptDangerFunction::PromptOrWait(int download_id, int retries) {

// DownloadDangerPrompt deletes itself

if (on_prompt_created_ && !on_prompt_created_->is_null())

on_prompt_created_->Run(prompt);

- SendResponse(error_.empty());

+ // Function finishes in DangerPromptCallback().

}

void DownloadsAcceptDangerFunction::DangerPromptCallback(