chrome/browser/extensions/api/web_view/chrome_web_view_internal_api.h - Issue 2017113002: [Extensions] DCHECK that ExtensionFunctions respond (and only once)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_view/chrome_web_view_internal_api.h

Issue 2017113002: [Extensions] DCHECK that ExtensionFunctions respond (and only once) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/web_request/web_request_apitest.cc ('k') | chrome/browser/extensions/api/web_view/chrome_web_view_internal_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_view/chrome_web_view_internal_api.h

diff --git a/chrome/browser/extensions/api/web_view/chrome_web_view_internal_api.h b/chrome/browser/extensions/api/web_view/chrome_web_view_internal_api.h

index d2c440fa282c635254b571024bc2c065a36b60c0..85b53791a436fc5a2295bb96e7571075f5d26f4f 100644

--- a/chrome/browser/extensions/api/web_view/chrome_web_view_internal_api.h

+++ b/chrome/browser/extensions/api/web_view/chrome_web_view_internal_api.h

@@ -94,10 +94,7 @@ class ChromeWebViewInternalShowContextMenuFunction

protected:

~ChromeWebViewInternalShowContextMenuFunction() override;

- private:

- // WebViewInternalExtensionFunction implementation.

- bool RunAsyncSafe(WebViewGuest* guest) override;

+ ResponseAction Run() override;

DISALLOW_COPY_AND_ASSIGN(ChromeWebViewInternalShowContextMenuFunction);

};