Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1170)

Unified Diff: chrome/browser/extensions/api/web_view/chrome_web_view_internal_api.cc

Issue 2017113002: [Extensions] DCHECK that ExtensionFunctions respond (and only once) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/web_view/chrome_web_view_internal_api.cc
diff --git a/chrome/browser/extensions/api/web_view/chrome_web_view_internal_api.cc b/chrome/browser/extensions/api/web_view/chrome_web_view_internal_api.cc
index c99c573792db120c6b137b239167e30e6b4053c1..a3f56b999e17175db1fa738fcad386d85b9f250c 100644
--- a/chrome/browser/extensions/api/web_view/chrome_web_view_internal_api.cc
+++ b/chrome/browser/extensions/api/web_view/chrome_web_view_internal_api.cc
@@ -140,17 +140,15 @@ ChromeWebViewInternalShowContextMenuFunction::
~ChromeWebViewInternalShowContextMenuFunction() {
}
-bool ChromeWebViewInternalShowContextMenuFunction::RunAsyncSafe(
- WebViewGuest* guest) {
+ExtensionFunction::ResponseAction
+ChromeWebViewInternalShowContextMenuFunction::Run() {
std::unique_ptr<webview::ShowContextMenu::Params> params(
webview::ShowContextMenu::Params::Create(*args_));
EXTENSION_FUNCTION_VALIDATE(params.get());
// TODO(lazyboy): Actually implement filtering menu items.
- guest->ShowContextMenu(params->request_id);
-
- SendResponse(true);
- return true;
+ guest_->ShowContextMenu(params->request_id);
+ return RespondNow(NoArguments());
}
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698