chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc - Issue 2017113002: [Extensions] DCHECK that ExtensionFunctions respond (and only once)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc

Issue 2017113002: [Extensions] DCHECK that ExtensionFunctions respond (and only once) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/downloads/downloads_api.cc ('k') | chrome/browser/extensions/api/hotword_private/hotword_private_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc

diff --git a/chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc b/chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc

index f5b70554a1730bb904c0a4818adc4cc395cb3067..009343c5d6d14feeab9d8938ebb55e8bd869a589 100644

--- a/chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc

+++ b/chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc

@@ -117,7 +117,7 @@ IN_PROC_BROWSER_TEST_F(BrowserActionInteractiveTest, TestOpenPopup) {

content::NOTIFICATION_LOAD_COMPLETED_MAIN_FRAME,

content::NotificationService::AllSources());

// Show second popup in new window.

- listener.Reply("");

+ listener.Reply("show another");

frame_observer.Wait();

EXPECT_TRUE(BrowserActionTestUtil(new_browser).HasPopup());

}

@@ -214,7 +214,7 @@ IN_PROC_BROWSER_TEST_F(BrowserActionInteractiveTest,

ResultCatcher catcher;

// Return control to javascript to validate that opening a popup fails now.

- listener.Reply("");

+ listener.Reply("show another");

ASSERT_TRUE(catcher.GetNextResult()) << message_;

}