Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5265)

Unified Diff: chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc

Issue 2017113002: [Extensions] DCHECK that ExtensionFunctions respond (and only once) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc
diff --git a/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc b/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc
index 22d35500df1d9955fe0e933468ec25e642949f57..30e14d6c483eadf2c4122731222a392fc76afffe 100644
--- a/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc
+++ b/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc
@@ -462,7 +462,8 @@ bool BookmarkManagerPrivateSortChildrenFunction::RunOnReady() {
return true;
}
-bool BookmarkManagerPrivateGetStringsFunction::RunAsync() {
+ExtensionFunction::ResponseAction
+BookmarkManagerPrivateGetStringsFunction::Run() {
std::unique_ptr<base::DictionaryValue> localized_strings(
new base::DictionaryValue());
@@ -536,13 +537,7 @@ bool BookmarkManagerPrivateGetStringsFunction::RunAsync() {
const std::string& app_locale = g_browser_process->GetApplicationLocale();
webui::SetLoadTimeDataDefaults(app_locale, localized_strings.get());
- SetResult(std::move(localized_strings));
-
- // This is needed because unlike the rest of these functions, this class
- // inherits from AsyncFunction directly, rather than BookmarkFunction.
- SendResponse(true);
-
- return true;
+ return RespondNow(OneArgument(std::move(localized_strings)));
}
bool BookmarkManagerPrivateStartDragFunction::RunOnReady() {

Powered by Google App Engine
This is Rietveld 408576698