chrome/test/data/extensions/api_test/browser_action/open_popup/open_popup_succeeds.js - Issue 2017113002: [Extensions] DCHECK that ExtensionFunctions respond (and only once)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/browser_action/open_popup/open_popup_succeeds.js

Issue 2017113002: [Extensions] DCHECK that ExtensionFunctions respond (and only once) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/api_test/browser_action/open_popup/open_popup_fails.js ('k') | chrome/test/data/extensions/api_test/hotword_private/audioHistory/test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/browser_action/open_popup/open_popup_succeeds.js

diff --git a/chrome/test/data/extensions/api_test/browser_action/open_popup/open_popup_succeeds.js b/chrome/test/data/extensions/api_test/browser_action/open_popup/open_popup_succeeds.js

index 182a56f626b3053d317ade4d3d360887c84971ac..2d618f2a52e500f26915200d278bf7ca5556305b 100644

--- a/chrome/test/data/extensions/api_test/browser_action/open_popup/open_popup_succeeds.js

+++ b/chrome/test/data/extensions/api_test/browser_action/open_popup/open_popup_succeeds.js

@@ -7,7 +7,9 @@

chrome.browserAction.openPopup(function(popupWindow) {

chrome.test.assertTrue(!!popupWindow);

chrome.test.notifyPass();

- chrome.test.sendMessage('ready', function() {

+ chrome.test.sendMessage('ready', function(reply) {

+ if (reply !== 'show another')

+ return;

chrome.browserAction.openPopup(function(popupWindow2) {

chrome.test.assertTrue(!!popupWindow2);

chrome.test.succeed();