Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6628)

Unified Diff: chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc

Issue 2017113002: [Extensions] DCHECK that ExtensionFunctions respond (and only once) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc
diff --git a/chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc b/chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc
index 3b1c37c6be9c4dc1c186396a72894632130a1fc7..fa734bcedea523accad4bd0a352009b8404e290d 100644
--- a/chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc
+++ b/chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc
@@ -122,7 +122,7 @@ class ComponentCloudPolicyTest : public ExtensionBrowserTest {
<< "Pre-existing policies in this machine will make this test fail.";
// Install the initial extension.
- ExtensionTestMessageListener ready_listener("ready", true);
+ ExtensionTestMessageListener ready_listener("ready", false);
event_listener_.reset(new ExtensionTestMessageListener("event", true));
extension_ = LoadExtension(kTestExtensionPath);
ASSERT_TRUE(extension_.get());
@@ -223,7 +223,7 @@ class ComponentCloudPolicyTest : public ExtensionBrowserTest {
IN_PROC_BROWSER_TEST_F(ComponentCloudPolicyTest, FetchExtensionPolicy) {
// Read the initial policy.
- ExtensionTestMessageListener policy_listener(kTestPolicyJSON, true);
+ ExtensionTestMessageListener policy_listener(kTestPolicyJSON, false);
event_listener_->Reply("get-policy-Name");
EXPECT_TRUE(policy_listener.WaitUntilSatisfied());
}
@@ -250,7 +250,7 @@ IN_PROC_BROWSER_TEST_F(ComponentCloudPolicyTest, UpdateExtensionPolicy) {
event_listener_->Reply("get-policy-Name");
EXPECT_TRUE(policy_listener1.WaitUntilSatisfied());
- ExtensionTestMessageListener policy_listener2(kTestPolicy2JSON, true);
+ ExtensionTestMessageListener policy_listener2(kTestPolicy2JSON, false);
policy_listener1.Reply("get-policy-Another");
EXPECT_TRUE(policy_listener2.WaitUntilSatisfied());
}
@@ -264,7 +264,7 @@ IN_PROC_BROWSER_TEST_F(ComponentCloudPolicyTest, InstallNewExtension) {
// the extension.
RefreshPolicies();
- ExtensionTestMessageListener result_listener("ok", true);
+ ExtensionTestMessageListener result_listener("ok", false);
result_listener.set_failure_message("fail");
scoped_refptr<const extensions::Extension> extension2 =
LoadExtension(kTestExtension2Path);
@@ -315,7 +315,7 @@ IN_PROC_BROWSER_TEST_F(ComponentCloudPolicyTest, SignOutAndBackIn) {
EXPECT_TRUE(event_listener.WaitUntilSatisfied());
// The extension got an update event; verify that the policy was empty.
- ExtensionTestMessageListener signout_policy_listener("{}", true);
+ ExtensionTestMessageListener signout_policy_listener("{}", false);
event_listener.Reply("get-policy-Name");
EXPECT_TRUE(signout_policy_listener.WaitUntilSatisfied());
@@ -328,7 +328,7 @@ IN_PROC_BROWSER_TEST_F(ComponentCloudPolicyTest, SignOutAndBackIn) {
EXPECT_TRUE(event_listener2.WaitUntilSatisfied());
// The extension got updated policy; verify it.
- ExtensionTestMessageListener signin_policy_listener(kTestPolicyJSON, true);
+ ExtensionTestMessageListener signin_policy_listener(kTestPolicyJSON, false);
event_listener2.Reply("get-policy-Name");
EXPECT_TRUE(signin_policy_listener.WaitUntilSatisfied());

Powered by Google App Engine
This is Rietveld 408576698