Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Unified Diff: chrome/browser/extensions/api/hotword_private/hotword_private_apitest.cc

Issue 2017113002: [Extensions] DCHECK that ExtensionFunctions respond (and only once) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/hotword_private/hotword_private_apitest.cc
diff --git a/chrome/browser/extensions/api/hotword_private/hotword_private_apitest.cc b/chrome/browser/extensions/api/hotword_private/hotword_private_apitest.cc
index 37699dffde3acd7495517cf76a58f10baa1aacb3..c8fc3c6746ddfac5e3296b043f5084d8cd9617e3 100644
--- a/chrome/browser/extensions/api/hotword_private/hotword_private_apitest.cc
+++ b/chrome/browser/extensions/api/hotword_private/hotword_private_apitest.cc
@@ -474,8 +474,9 @@ IN_PROC_BROWSER_TEST_F(HotwordPrivateApiTest, AudioHistory) {
service()->SetAudioHistoryHandler(handler);
web_history->SetExpectedValue(true);
- ExtensionTestMessageListener setListenerT("set AH: true success", false);
- ExtensionTestMessageListener setListenerF("set AH: false success", false);
+ ExtensionTestMessageListener setListenerT("set AH True: true success", false);
+ ExtensionTestMessageListener setListenerF("set AH False: false success",
+ false);
ExtensionTestMessageListener getListener("get AH: true success", false);
ASSERT_TRUE(RunComponentExtensionTest("audioHistory")) << message_;
@@ -486,8 +487,10 @@ IN_PROC_BROWSER_TEST_F(HotwordPrivateApiTest, AudioHistory) {
web_history->SetExpectedValue(false);
- ExtensionTestMessageListener setListenerT2("set AH: true success", false);
- ExtensionTestMessageListener setListenerF2("set AH: false success", false);
+ ExtensionTestMessageListener setListenerT2("set AH True: true success",
+ false);
+ ExtensionTestMessageListener setListenerF2("set AH False: false success",
+ false);
ExtensionTestMessageListener getListener2("get AH: false success", false);
ASSERT_TRUE(RunComponentExtensionTest("audioHistory")) << message_;
@@ -506,8 +509,9 @@ IN_PROC_BROWSER_TEST_F(HotwordPrivateApiTest, AudioHistoryNoWebHistory) {
PrefService* prefs = profile()->GetPrefs();
prefs->SetBoolean(prefs::kHotwordAudioLoggingEnabled, true);
- ExtensionTestMessageListener setListenerT("set AH: true failure", false);
- ExtensionTestMessageListener setListenerF("set AH: true failure", false);
+ ExtensionTestMessageListener setListenerT("set AH True: true failure", false);
+ ExtensionTestMessageListener setListenerF("set AH False: true failure",
+ false);
ExtensionTestMessageListener getListener("get AH: true failure", false);
ASSERT_TRUE(RunComponentExtensionTest("audioHistory")) << message_;
@@ -523,12 +527,13 @@ IN_PROC_BROWSER_TEST_F(HotwordPrivateApiTest, AudioHistoryWebHistoryFailure) {
new MockAudioHistoryHandler(profile(), web_history);
service()->SetAudioHistoryHandler(handler);
web_history->SetFailureState();
- // It shouldn't matter if this is set to true. GetAduioHistoryEnabled should
+ // It shouldn't matter if this is set to true. GetAudioHistoryEnabled should
// still return false.
web_history->SetExpectedValue(true);
- ExtensionTestMessageListener setListenerT("set AH: false failure", false);
- ExtensionTestMessageListener setListenerF("set AH: false failure", false);
+ ExtensionTestMessageListener setListenerT("set AH True: true failure", false);
+ ExtensionTestMessageListener setListenerF("set AH False: false failure",
+ false);
ExtensionTestMessageListener getListener("get AH: false failure", false);
ASSERT_TRUE(RunComponentExtensionTest("audioHistory")) << message_;

Powered by Google App Engine
This is Rietveld 408576698