[Extensions] DCHECK that ExtensionFunctions respond (and only once)

chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/base64url.h"
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
@@ skipping 104 matching lines @@
     command_line->AppendSwitchASCII(switches::kDeviceManagementUrl, url);
 
     ExtensionBrowserTest::SetUpInProcessBrowserTestFixture();
   }
 
   void SetUpOnMainThread() override {
     ASSERT_TRUE(PolicyServiceIsEmpty(g_browser_process->policy_service()))
         << "Pre-existing policies in this machine will make this test fail.";
 
     // Install the initial extension.
-    ExtensionTestMessageListener ready_listener("ready", true);
+    ExtensionTestMessageListener ready_listener("ready", false);
     event_listener_.reset(new ExtensionTestMessageListener("event", true));
     extension_ = LoadExtension(kTestExtensionPath);
     ASSERT_TRUE(extension_.get());
     ASSERT_EQ(kTestExtension, extension_->id());
     EXPECT_TRUE(ready_listener.WaitUntilSatisfied());
 
     // And start with a signed-in user.
     SignInAndRegister();
 
     // The extension will receive an update event.
@@ skipping 80 matching lines @@
     run_loop.Run();
   }
 
   LocalPolicyTestServer test_server_;
   scoped_refptr<const extensions::Extension> extension_;
   std::unique_ptr<ExtensionTestMessageListener> event_listener_;
 };
 
 IN_PROC_BROWSER_TEST_F(ComponentCloudPolicyTest, FetchExtensionPolicy) {
   // Read the initial policy.
-  ExtensionTestMessageListener policy_listener(kTestPolicyJSON, true);
+  ExtensionTestMessageListener policy_listener(kTestPolicyJSON, false);
   event_listener_->Reply("get-policy-Name");
   EXPECT_TRUE(policy_listener.WaitUntilSatisfied());
 }
 
 IN_PROC_BROWSER_TEST_F(ComponentCloudPolicyTest, UpdateExtensionPolicy) {
   // Read the initial policy.
   ExtensionTestMessageListener policy_listener(kTestPolicyJSON, true);
   event_listener_->Reply("get-policy-Name");
   EXPECT_TRUE(policy_listener.WaitUntilSatisfied());
 
   // Update the policy at the server and reload policy.
   event_listener_.reset(new ExtensionTestMessageListener("event", true));
   policy_listener.Reply("idle");
   EXPECT_TRUE(test_server_.UpdatePolicyData(
       dm_protocol::kChromeExtensionPolicyType, kTestExtension, kTestPolicy2));
   RefreshPolicies();
 
   // Check that the update event was received, and verify the new policy
   // values.
   EXPECT_TRUE(event_listener_->WaitUntilSatisfied());
 
   // This policy was removed.
   ExtensionTestMessageListener policy_listener1("{}", true);
   event_listener_->Reply("get-policy-Name");
   EXPECT_TRUE(policy_listener1.WaitUntilSatisfied());
 
-  ExtensionTestMessageListener policy_listener2(kTestPolicy2JSON, true);
+  ExtensionTestMessageListener policy_listener2(kTestPolicy2JSON, false);
   policy_listener1.Reply("get-policy-Another");
   EXPECT_TRUE(policy_listener2.WaitUntilSatisfied());
 }
 
 IN_PROC_BROWSER_TEST_F(ComponentCloudPolicyTest, InstallNewExtension) {
   EXPECT_TRUE(test_server_.UpdatePolicyData(
       dm_protocol::kChromeExtensionPolicyType, kTestExtension2, kTestPolicy2));
   // Installing a new extension doesn't trigger another policy fetch because
   // the server always sends down the list of all extensions that have policy.
   // Fetch now that the configuration has been updated and before installing
   // the extension.
   RefreshPolicies();
 
-  ExtensionTestMessageListener result_listener("ok", true);
+  ExtensionTestMessageListener result_listener("ok", false);
   result_listener.set_failure_message("fail");
   scoped_refptr<const extensions::Extension> extension2 =
       LoadExtension(kTestExtension2Path);
   ASSERT_TRUE(extension2.get());
   ASSERT_EQ(kTestExtension2, extension2->id());
 
   // This extension only sends the 'policy' signal once it receives the policy,
   // and after verifying it has the expected value. Otherwise it sends 'fail'.
   EXPECT_TRUE(result_listener.WaitUntilSatisfied());
 }
@@ skipping 30 matching lines @@
   EXPECT_TRUE(base::PathExists(cache_path));
 
   // Now sign-out. The policy cache should be removed, and the extension should
   // get an empty policy update.
   ExtensionTestMessageListener event_listener("event", true);
   initial_policy_listener.Reply("idle");
   SignOut();
   EXPECT_TRUE(event_listener.WaitUntilSatisfied());
 
   // The extension got an update event; verify that the policy was empty.
-  ExtensionTestMessageListener signout_policy_listener("{}", true);
+  ExtensionTestMessageListener signout_policy_listener("{}", false);
   event_listener.Reply("get-policy-Name");
   EXPECT_TRUE(signout_policy_listener.WaitUntilSatisfied());
 
   // Verify that the cache is gone.
   EXPECT_FALSE(base::PathExists(cache_path));
 
   // Verify that the policy is fetched again if the user signs back in.
   ExtensionTestMessageListener event_listener2("event", true);
   SignInAndRegister();
   EXPECT_TRUE(event_listener2.WaitUntilSatisfied());
 
   // The extension got updated policy; verify it.
-  ExtensionTestMessageListener signin_policy_listener(kTestPolicyJSON, true);
+  ExtensionTestMessageListener signin_policy_listener(kTestPolicyJSON, false);
   event_listener2.Reply("get-policy-Name");
   EXPECT_TRUE(signin_policy_listener.WaitUntilSatisfied());
 
   // And the cache is back.
   EXPECT_TRUE(base::PathExists(cache_path));
 }
 #endif
 
 }  // namespace policy