extensions/browser/api_test_utils.cc - Issue 2017113002: [Extensions] DCHECK that ExtensionFunctions respond (and only once)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api_test_utils.cc

Issue 2017113002: [Extensions] DCHECK that ExtensionFunctions respond (and only once) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/api_test_utils.cc

diff --git a/extensions/browser/api_test_utils.cc b/extensions/browser/api_test_utils.cc

index 0dafbbe00789b69248ffe745a71cecc8337886e9..d6116e8b58c4466d4bd72f6687db11d333ad4931 100644

--- a/extensions/browser/api_test_utils.cc

+++ b/extensions/browser/api_test_utils.cc

@@ -234,7 +234,7 @@ bool RunFunction(

function->set_browser_context(context);

function->set_include_incognito(flags & INCLUDE_INCOGNITO);

- function->Run()->Execute();

+ function->RunWithValidation()->Execute();

response_delegate.WaitForResponse();

EXPECT_TRUE(response_delegate.HasResponse());

« no previous file with comments | « extensions/browser/api/test/test_api.cc ('k') | extensions/browser/extension_function.h » ('j') | no next file with comments »