Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: extensions/browser/extension_function_dispatcher.cc

Issue 2017113002: [Extensions] DCHECK that ExtensionFunctions respond (and only once) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/extension_function.cc ('k') | extensions/test/extension_test_message_listener.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/extension_function_dispatcher.cc
diff --git a/extensions/browser/extension_function_dispatcher.cc b/extensions/browser/extension_function_dispatcher.cc
index 96b333cee7defb32c7c2a225c8e0d8db1c80bedd..502bec4b8cb0c49785c3d740ef6ed9eae1659765 100644
--- a/extensions/browser/extension_function_dispatcher.cc
+++ b/extensions/browser/extension_function_dispatcher.cc
@@ -374,7 +374,7 @@ void ExtensionFunctionDispatcher::DispatchOnIOThread(
if (!extension) {
// Skip all of the UMA, quota, event page, activity logging stuff if there
// isn't an extension, e.g. if the function call was from WebUI.
- function->Run()->Execute();
+ function->RunWithValidation()->Execute();
return;
}
@@ -393,7 +393,7 @@ void ExtensionFunctionDispatcher::DispatchOnIOThread(
FROM_HERE_WITH_EXPLICIT_FUNCTION(function->name()),
tracked_objects::ScopedProfile::ENABLED);
base::ElapsedTimer timer;
- function->Run()->Execute();
+ function->RunWithValidation()->Execute();
// TODO(devlin): Once we have a baseline metric for how long functions take,
// we can create a handful of buckets and record the function name so that
// we can find what the fastest/slowest are.
@@ -506,7 +506,7 @@ void ExtensionFunctionDispatcher::DispatchWithCallbackInternal(
if (!extension) {
// Skip all of the UMA, quota, event page, activity logging stuff if there
// isn't an extension, e.g. if the function call was from WebUI.
- function->Run()->Execute();
+ function->RunWithValidation()->Execute();
return;
}
@@ -533,7 +533,7 @@ void ExtensionFunctionDispatcher::DispatchWithCallbackInternal(
FROM_HERE_WITH_EXPLICIT_FUNCTION(function->name()),
tracked_objects::ScopedProfile::ENABLED);
base::ElapsedTimer timer;
- function->Run()->Execute();
+ function->RunWithValidation()->Execute();
// TODO(devlin): Once we have a baseline metric for how long functions take,
// we can create a handful of buckets and record the function name so that
// we can find what the fastest/slowest are.
« no previous file with comments | « extensions/browser/extension_function.cc ('k') | extensions/test/extension_test_message_listener.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698