chrome/browser/extensions/api/web_request/web_request_apitest.cc - Issue 2017113002: [Extensions] DCHECK that ExtensionFunctions respond (and only once)

Unified Diff: chrome/browser/extensions/api/web_request/web_request_apitest.cc

Issue 2017113002: [Extensions] DCHECK that ExtensionFunctions respond (and only once) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc ('k') | chrome/browser/extensions/api/web_view/chrome_web_view_internal_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_request/web_request_apitest.cc

diff --git a/chrome/browser/extensions/api/web_request/web_request_apitest.cc b/chrome/browser/extensions/api/web_request/web_request_apitest.cc

index d9750daef3d58625a9bed874e5ceb416ce7faffb..048352ad925e7294631c5e960778619ca0d39970 100644

--- a/chrome/browser/extensions/api/web_request/web_request_apitest.cc

+++ b/chrome/browser/extensions/api/web_request/web_request_apitest.cc

@@ -278,8 +278,8 @@ void ExtensionWebRequestApiTest::RunPermissionTest(

catcher_incognito.RestrictToBrowserContext(

browser()->profile()->GetOffTheRecordProfile());

- ExtensionTestMessageListener listener("done", true);

- ExtensionTestMessageListener listener_incognito("done_incognito", true);

+ ExtensionTestMessageListener listener("done", false);

+ ExtensionTestMessageListener listener_incognito("done_incognito", false);

int load_extension_flags = kFlagNone;

if (load_extension_with_incognito_permission)

@@ -390,8 +390,8 @@ IN_PROC_BROWSER_TEST_F(ExtensionWebRequestApiTest,

IN_PROC_BROWSER_TEST_F(ExtensionWebRequestApiTest, IncognitoSplitModeReload) {

ASSERT_TRUE(StartEmbeddedTestServer());

// Wait for rules to be set up.

- ExtensionTestMessageListener listener("done", true);

- ExtensionTestMessageListener listener_incognito("done_incognito", true);

+ ExtensionTestMessageListener listener("done", false);

+ ExtensionTestMessageListener listener_incognito("done_incognito", false);

const Extension* extension = LoadExtensionWithFlags(

test_data_dir_.AppendASCII("webrequest_reload"), kFlagEnableIncognito);

@@ -403,8 +403,8 @@ IN_PROC_BROWSER_TEST_F(ExtensionWebRequestApiTest, IncognitoSplitModeReload) {

// Reload extension and wait for rules to be set up again. This should not

// crash the browser.

- ExtensionTestMessageListener listener2("done", true);

- ExtensionTestMessageListener listener_incognito2("done_incognito", true);

+ ExtensionTestMessageListener listener2("done", false);

+ ExtensionTestMessageListener listener_incognito2("done_incognito", false);

ReloadExtension(extension->id());

@@ -418,7 +418,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionWebRequestApiTest, ExtensionRequests) {

ExtensionTestMessageListener listener_main2("web_request_status2", true);

ExtensionTestMessageListener listener_app("app_done", false);

- ExtensionTestMessageListener listener_extension("extension_done", true);

+ ExtensionTestMessageListener listener_extension("extension_done", false);

// Set up webRequest listener

ASSERT_TRUE(LoadExtension(