chrome/browser/extensions/api/declarative_content/set_icon_apitest.cc - Issue 2017113002: [Extensions] DCHECK that ExtensionFunctions respond (and only once)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative_content/set_icon_apitest.cc

Issue 2017113002: [Extensions] DCHECK that ExtensionFunctions respond (and only once) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc ('k') | chrome/browser/extensions/api/downloads/downloads_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative_content/set_icon_apitest.cc

diff --git a/chrome/browser/extensions/api/declarative_content/set_icon_apitest.cc b/chrome/browser/extensions/api/declarative_content/set_icon_apitest.cc

index b29d47fd2a7619c1ba54b298a0ca13b7c4ec48df..a1936a2a4a3a1f2ee4bc37aec58b9f7e4bb394e7 100644

--- a/chrome/browser/extensions/api/declarative_content/set_icon_apitest.cc

+++ b/chrome/browser/extensions/api/declarative_content/set_icon_apitest.cc

@@ -71,7 +71,7 @@ IN_PROC_BROWSER_TEST_F(SetIconAPITest, Overview) {

" })\n"

" });\n"

"});\n");

- ExtensionTestMessageListener ready("ready", true);

+ ExtensionTestMessageListener ready("ready", false);

const Extension* extension = LoadExtension(ext_dir_.unpacked_path());

ASSERT_TRUE(extension);

const ExtensionAction* page_action =