[Extensions] DCHECK that ExtensionFunctions respond (and only once)

chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <memory>
@@ skipping 444 matching lines @@
   EXTENSION_FUNCTION_VALIDATE(params);
 
   BookmarkModel* model = BookmarkModelFactory::GetForProfile(GetProfile());
   const BookmarkNode* parent_node = GetNodeFromString(model, params->parent_id);
   if (!CanBeModified(parent_node))
     return false;
   model->SortChildren(parent_node);
   return true;
 }
 
-bool BookmarkManagerPrivateGetStringsFunction::RunAsync() {
+ExtensionFunction::ResponseAction
+BookmarkManagerPrivateGetStringsFunction::Run() {
   std::unique_ptr<base::DictionaryValue> localized_strings(
       new base::DictionaryValue());
 
   localized_strings->SetString("title",
       l10n_util::GetStringUTF16(IDS_BOOKMARK_MANAGER_TITLE));
   localized_strings->SetString("search_button",
       l10n_util::GetStringUTF16(IDS_BOOKMARK_MANAGER_SEARCH_BUTTON));
   localized_strings->SetString("folders_menu",
       l10n_util::GetStringUTF16(IDS_BOOKMARK_MANAGER_FOLDERS_MENU));
   localized_strings->SetString("organize_menu",
@@ skipping 53 matching lines @@
   localized_strings->SetString("search",
       l10n_util::GetStringUTF16(IDS_BOOKMARK_MANAGER_SEARCH));
   localized_strings->SetString("save",
       l10n_util::GetStringUTF16(IDS_SAVE));
   localized_strings->SetString("cancel",
       l10n_util::GetStringUTF16(IDS_CANCEL));
 
   const std::string& app_locale = g_browser_process->GetApplicationLocale();
   webui::SetLoadTimeDataDefaults(app_locale, localized_strings.get());
 
-  SetResult(std::move(localized_strings));
-
-  // This is needed because unlike the rest of these functions, this class
-  // inherits from AsyncFunction directly, rather than BookmarkFunction.
-  SendResponse(true);
-
-  return true;
+  return RespondNow(OneArgument(std::move(localized_strings)));
 }
 
 bool BookmarkManagerPrivateStartDragFunction::RunOnReady() {
   if (!EditBookmarksEnabled())
     return false;
 
   if (GetViewType(GetSenderWebContents()) != VIEW_TYPE_TAB_CONTENTS) {
     NOTREACHED();
     return false;
   }
@@ skipping 299 matching lines @@
 
   RedoInfo::Results::Result result;
   result.enabled = undo_manager->redo_count() > 0;
   result.label = base::UTF16ToUTF8(undo_manager->GetRedoLabel());
 
   results_ = RedoInfo::Results::Create(result);
   return true;
 }
 
 }  // namespace extensions