[Extensions] DCHECK that ExtensionFunctions respond (and only once)

extensions/browser/api/guest_view/web_view/web_view_internal_api.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_BROWSER_API_WEB_VIEW_WEB_VIEW_INTERNAL_API_H_
 #define EXTENSIONS_BROWSER_API_WEB_VIEW_WEB_VIEW_INTERNAL_API_H_
 
 #include <stdint.h>
 
 #include "base/macros.h"
 #include "extensions/browser/api/execute_code_function.h"
 #include "extensions/browser/api/web_contents_capture_client.h"
 #include "extensions/browser/extension_function.h"
 #include "extensions/browser/guest_view/web_view/web_ui/web_ui_url_fetcher.h"
 #include "extensions/browser/guest_view/web_view/web_view_guest.h"
 
 // WARNING: WebViewInternal could be loaded in an unblessed context, thus any
 // new APIs must extend WebViewInternalExtensionFunction or
 // WebViewInternalExecuteCodeFunction which do a process ID check to prevent
 // abuse by normal renderer processes.
 namespace extensions {
 
 // An abstract base class for async webview APIs. It does a process ID check
 // in RunAsync, and then calls RunAsyncSafe which must be overriden by all
 // subclasses.
-class WebViewInternalExtensionFunction : public AsyncExtensionFunction {
+class LegacyWebViewInternalExtensionFunction : public AsyncExtensionFunction {
  public:
-  WebViewInternalExtensionFunction() {}
+  LegacyWebViewInternalExtensionFunction() {}
 
  protected:
-  ~WebViewInternalExtensionFunction() override {}
+  ~LegacyWebViewInternalExtensionFunction() override {}
 
   // ExtensionFunction implementation.
   bool RunAsync() final;
 
  private:
   virtual bool RunAsyncSafe(WebViewGuest* guest) = 0;
 };
 
+class WebViewInternalExtensionFunction : public UIThreadExtensionFunction {
+ public:
+  WebViewInternalExtensionFunction() {}
+
+ protected:
+  ~WebViewInternalExtensionFunction() override {}
+  bool PreRunValidation(std::string* error) override;
+
+  WebViewGuest* guest_ = nullptr;
+};
+
 class WebViewInternalCaptureVisibleRegionFunction
-    : public WebViewInternalExtensionFunction,
+    : public LegacyWebViewInternalExtensionFunction,
       public WebContentsCaptureClient {
  public:
   DECLARE_EXTENSION_FUNCTION("webViewInternal.captureVisibleRegion",
                              WEBVIEWINTERNAL_CAPTUREVISIBLEREGION);
   WebViewInternalCaptureVisibleRegionFunction();
 
  protected:
   ~WebViewInternalCaptureVisibleRegionFunction() override {}
 
  private:
-  // WebViewInternalExtensionFunction implementation.
+  // LegacyWebViewInternalExtensionFunction implementation.
   bool RunAsyncSafe(WebViewGuest* guest) override;
 
   // extensions::WebContentsCaptureClient:
   bool IsScreenshotEnabled() override;
   bool ClientAllowsTransparency() override;
   void OnCaptureSuccess(const SkBitmap& bitmap) override;
   void OnCaptureFailure(FailureReason reason) override;
 
   bool is_guest_transparent_;
 
   DISALLOW_COPY_AND_ASSIGN(WebViewInternalCaptureVisibleRegionFunction);
 };
 
 class WebViewInternalNavigateFunction
     : public WebViewInternalExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("webViewInternal.navigate",
                              WEBVIEWINTERNAL_NAVIGATE);
   WebViewInternalNavigateFunction() {}
 
  protected:
   ~WebViewInternalNavigateFunction() override {}
-
- private:
-  // WebViewInternalExtensionFunction implementation.
-  bool RunAsyncSafe(WebViewGuest* guest) override;
+  ResponseAction Run() override;
 
   DISALLOW_COPY_AND_ASSIGN(WebViewInternalNavigateFunction);
 };
 
 class WebViewInternalExecuteCodeFunction
     : public extensions::ExecuteCodeFunction {
  public:
   WebViewInternalExecuteCodeFunction();
 
  protected:
@@ skipping 99 matching lines @@
 
 class WebViewInternalSetNameFunction : public WebViewInternalExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("webViewInternal.setName",
                              WEBVIEWINTERNAL_SETNAME);
 
   WebViewInternalSetNameFunction();
 
  protected:
   ~WebViewInternalSetNameFunction() override;
-
- private:
-  bool RunAsyncSafe(WebViewGuest* guest) override;
+  ResponseAction Run() override;
 
   DISALLOW_COPY_AND_ASSIGN(WebViewInternalSetNameFunction);
 };
 
-class WebViewInternalSetAllowTransparencyFunction :
-    public WebViewInternalExtensionFunction {
+class WebViewInternalSetAllowTransparencyFunction
+    : public WebViewInternalExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("webViewInternal.setAllowTransparency",
                              WEBVIEWINTERNAL_SETALLOWTRANSPARENCY);
 
   WebViewInternalSetAllowTransparencyFunction();
 
  protected:
   ~WebViewInternalSetAllowTransparencyFunction() override;
-
- private:
-  bool RunAsyncSafe(WebViewGuest* guest) override;
+  ResponseAction Run() override;
 
   DISALLOW_COPY_AND_ASSIGN(WebViewInternalSetAllowTransparencyFunction);
 };
 
 class WebViewInternalSetAllowScalingFunction
     : public WebViewInternalExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("webViewInternal.setAllowScaling",
                              WEBVIEWINTERNAL_SETALLOWSCALING);
 
   WebViewInternalSetAllowScalingFunction();
 
  protected:
   ~WebViewInternalSetAllowScalingFunction() override;
-
- private:
-  bool RunAsyncSafe(WebViewGuest* guest) override;
+  ResponseAction Run() override;
 
   DISALLOW_COPY_AND_ASSIGN(WebViewInternalSetAllowScalingFunction);
 };
 
 class WebViewInternalSetZoomFunction : public WebViewInternalExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("webViewInternal.setZoom",
                              WEBVIEWINTERNAL_SETZOOM);
 
   WebViewInternalSetZoomFunction();
 
  protected:
   ~WebViewInternalSetZoomFunction() override;
-
- private:
-  bool RunAsyncSafe(WebViewGuest* guest) override;
+  ResponseAction Run() override;
 
   DISALLOW_COPY_AND_ASSIGN(WebViewInternalSetZoomFunction);
 };
 
 class WebViewInternalGetZoomFunction : public WebViewInternalExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("webViewInternal.getZoom",
                              WEBVIEWINTERNAL_GETZOOM);
 
   WebViewInternalGetZoomFunction();
 
  protected:
   ~WebViewInternalGetZoomFunction() override;
-
- private:
-  bool RunAsyncSafe(WebViewGuest* guest) override;
+  ResponseAction Run() override;
 
   DISALLOW_COPY_AND_ASSIGN(WebViewInternalGetZoomFunction);
 };
 
 class WebViewInternalSetZoomModeFunction
     : public WebViewInternalExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("webViewInternal.setZoomMode",
                              WEBVIEWINTERNAL_SETZOOMMODE);
 
   WebViewInternalSetZoomModeFunction();
 
  protected:
   ~WebViewInternalSetZoomModeFunction() override;
-
- private:
-  bool RunAsyncSafe(WebViewGuest* guest) override;
+  ResponseAction Run() override;
 
   DISALLOW_COPY_AND_ASSIGN(WebViewInternalSetZoomModeFunction);
 };
 
 class WebViewInternalGetZoomModeFunction
     : public WebViewInternalExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("webViewInternal.getZoomMode",
                              WEBVIEWINTERNAL_GETZOOMMODE);
 
   WebViewInternalGetZoomModeFunction();
 
  protected:
   ~WebViewInternalGetZoomModeFunction() override;
-
- private:
-  bool RunAsyncSafe(WebViewGuest* guest) override;
+  ResponseAction Run() override;
 
   DISALLOW_COPY_AND_ASSIGN(WebViewInternalGetZoomModeFunction);
 };
 
-class WebViewInternalFindFunction : public WebViewInternalExtensionFunction {
+class WebViewInternalFindFunction
+    : public LegacyWebViewInternalExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("webViewInternal.find", WEBVIEWINTERNAL_FIND);
 
   WebViewInternalFindFunction();
 
   // Exposes SendResponse() for use by WebViewInternalFindHelper.
-  using WebViewInternalExtensionFunction::SendResponse;
+  using LegacyWebViewInternalExtensionFunction::SendResponse;
 
  protected:
   ~WebViewInternalFindFunction() override;
 
  private:
-  // WebViewInternalExtensionFunction implementation.
+  // LegacyWebViewInternalExtensionFunction implementation.
   bool RunAsyncSafe(WebViewGuest* guest) override;
 
   DISALLOW_COPY_AND_ASSIGN(WebViewInternalFindFunction);
 };
 
 class WebViewInternalStopFindingFunction
     : public WebViewInternalExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("webViewInternal.stopFinding",
                              WEBVIEWINTERNAL_STOPFINDING);
 
   WebViewInternalStopFindingFunction();
 
  protected:
   ~WebViewInternalStopFindingFunction() override;
-
- private:
-  // WebViewInternalExtensionFunction implementation.
-  bool RunAsyncSafe(WebViewGuest* guest) override;
+  ResponseAction Run() override;
 
   DISALLOW_COPY_AND_ASSIGN(WebViewInternalStopFindingFunction);
 };
 
 class WebViewInternalLoadDataWithBaseUrlFunction
     : public WebViewInternalExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("webViewInternal.loadDataWithBaseUrl",
                              WEBVIEWINTERNAL_LOADDATAWITHBASEURL);
 
   WebViewInternalLoadDataWithBaseUrlFunction();
 
  protected:
   ~WebViewInternalLoadDataWithBaseUrlFunction() override;
-
- private:
-  bool RunAsyncSafe(WebViewGuest* guest) override;
+  ResponseAction Run() override;
 
   DISALLOW_COPY_AND_ASSIGN(WebViewInternalLoadDataWithBaseUrlFunction);
 };
 
 class WebViewInternalGoFunction : public WebViewInternalExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("webViewInternal.go", WEBVIEWINTERNAL_GO);
 
   WebViewInternalGoFunction();
 
  protected:
   ~WebViewInternalGoFunction() override;
-
- private:
-  // WebViewInternalExtensionFunction implementation.
-  bool RunAsyncSafe(WebViewGuest* guest) override;
+  ResponseAction Run() override;
 
   DISALLOW_COPY_AND_ASSIGN(WebViewInternalGoFunction);
 };
 
 class WebViewInternalReloadFunction : public WebViewInternalExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("webViewInternal.reload", WEBVIEWINTERNAL_RELOAD);
 
   WebViewInternalReloadFunction();
 
  protected:
   ~WebViewInternalReloadFunction() override;
-
- private:
-  // WebViewInternalExtensionFunction implementation.
-  bool RunAsyncSafe(WebViewGuest* guest) override;
+  ResponseAction Run() override;
 
   DISALLOW_COPY_AND_ASSIGN(WebViewInternalReloadFunction);
 };
 
 class WebViewInternalSetPermissionFunction
     : public WebViewInternalExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("webViewInternal.setPermission",
                              WEBVIEWINTERNAL_SETPERMISSION);
 
   WebViewInternalSetPermissionFunction();
 
  protected:
   ~WebViewInternalSetPermissionFunction() override;
-
- private:
-  // WebViewInternalExtensionFunction implementation.
-  bool RunAsyncSafe(WebViewGuest* guest) override;
+  ResponseAction Run() override;
 
   DISALLOW_COPY_AND_ASSIGN(WebViewInternalSetPermissionFunction);
 };
 
 class WebViewInternalOverrideUserAgentFunction
     : public WebViewInternalExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("webViewInternal.overrideUserAgent",
                              WEBVIEWINTERNAL_OVERRIDEUSERAGENT);
 
   WebViewInternalOverrideUserAgentFunction();
 
  protected:
   ~WebViewInternalOverrideUserAgentFunction() override;
-
- private:
-  // WebViewInternalExtensionFunction implementation.
-  bool RunAsyncSafe(WebViewGuest* guest) override;
+  ResponseAction Run() override;
 
   DISALLOW_COPY_AND_ASSIGN(WebViewInternalOverrideUserAgentFunction);
 };
 
 class WebViewInternalStopFunction : public WebViewInternalExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("webViewInternal.stop", WEBVIEWINTERNAL_STOP);
 
   WebViewInternalStopFunction();
 
  protected:
   ~WebViewInternalStopFunction() override;
-
- private:
-  // WebViewInternalExtensionFunction implementation.
-  bool RunAsyncSafe(WebViewGuest* guest) override;
+  ResponseAction Run() override;
 
   DISALLOW_COPY_AND_ASSIGN(WebViewInternalStopFunction);
 };
 
 class WebViewInternalTerminateFunction
     : public WebViewInternalExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("webViewInternal.terminate",
                              WEBVIEWINTERNAL_TERMINATE);
 
   WebViewInternalTerminateFunction();
 
  protected:
   ~WebViewInternalTerminateFunction() override;
-
- private:
-  // WebViewInternalExtensionFunction implementation.
-  bool RunAsyncSafe(WebViewGuest* guest) override;
+  ResponseAction Run() override;
 
   DISALLOW_COPY_AND_ASSIGN(WebViewInternalTerminateFunction);
 };
 
 class WebViewInternalClearDataFunction
-    : public WebViewInternalExtensionFunction {
+    : public LegacyWebViewInternalExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("webViewInternal.clearData",
                              WEBVIEWINTERNAL_CLEARDATA);
 
   WebViewInternalClearDataFunction();
 
  protected:
   ~WebViewInternalClearDataFunction() override;
 
  private:
-  // WebViewInternalExtensionFunction implementation.
+  // LegacyWebViewInternalExtensionFunction implementation.
   bool RunAsyncSafe(WebViewGuest* guest) override;
 
   uint32_t GetRemovalMask();
   void ClearDataDone();
 
   // Removal start time.
   base::Time remove_since_;
   // Removal mask, corresponds to StoragePartition::RemoveDataMask enum.
   uint32_t remove_mask_;
   // Tracks any data related or parse errors.
   bool bad_message_;
 
   DISALLOW_COPY_AND_ASSIGN(WebViewInternalClearDataFunction);
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_API_WEB_VIEW_WEB_VIEW_INTERNAL_API_H_