Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 2004313003: DevTools: migrate from OwnPtr to std::unique_ptr for inspector protocol classes. (Closed)

Created:
4 years, 7 months ago by pfeldman
Modified:
4 years, 7 months ago
CC:
chromium-reviews, shans, apavlov+blink_chromium.org, dmazzoni+watch_chromium.org, kinuko+watch, caseq+blink_chromium.org, aboxhall, aboxhall+watch_chromium.org, je_julie, blink-reviews-bindings_chromium.org, devtools-reviews_chromium.org, blink-reviews, Eric Willigers, rjwright, cmumford, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, dmazzoni, yuzo+watch_chromium.org, darktears, haraken, jsbell+idb_chromium.org, blink-reviews-animation_chromium.org, nektar+watch_chromium.org, pfeldman+blink_chromium.org, nektarios, dtseng+watch_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: migrate from OwnPtr to std::unique_ptr for inspector protocol classes. BUG=580337 NOTRY=true Committed: https://crrev.com/229b1f8945646f00a834ec88bc97fe738561ff0a Cr-Commit-Position: refs/heads/master@{#395765}

Patch Set 1 #

Patch Set 2 : rebaselined #

Patch Set 3 : rebaselined #

Patch Set 4 : rebaselined #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1016 lines, -1019 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptCallStack.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptCallStack.cpp View 1 2 5 chunks +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/SourceLocation.h View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/SourceLocation.cpp View 1 2 3 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/ConsoleMessage.h View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/ConsoleMessage.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.h View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp View 9 chunks +14 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.h View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.cpp View 7 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.h View 4 chunks +18 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp View 28 chunks +38 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h View 4 chunks +17 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp View 29 chunks +34 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp View 16 chunks +20 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorHighlight.h View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp View 8 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInputAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInputAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.h View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp View 11 chunks +19 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorPageAgent.h View 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp View 8 chunks +18 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorResourceAgent.h View 4 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp View 1 2 3 21 chunks +28 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorSession.h View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorSession.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorStyleSheet.h View 5 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp View 18 chunks +28 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorTracingAgent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/LayoutEditor.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/LayoutEditor.cpp View 8 chunks +17 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/ThreadDebugger.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp View 6 chunks +14 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.h View 1 chunk +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.cpp View 4 chunks +21 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.h View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp View 19 chunks +23 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.h View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp View 21 chunks +36 lines, -36 lines 0 comments Download
M third_party/WebKit/Source/modules/storage/InspectorDOMStorageAgent.h View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/storage/InspectorDOMStorageAgent.cpp View 7 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.cpp View 4 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseResource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/Array.h View 6 chunks +15 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/Backend_h.template View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py View 4 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/CollectionsSTL.h View 11 chunks +24 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/CollectionsWTF.h View 7 chunks +20 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_cpp.template View 15 chunks +24 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_h.template View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/Frontend_cpp.template View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/Maybe.h View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/Parser.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/Parser.cpp View 6 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/ParserTest.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_cpp.template View 4 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template View 6 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/ValueConversions.h View 6 chunks +16 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/ValueConversions.cpp View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/Values.h View 9 chunks +32 lines, -32 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/Values.cpp View 8 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h View 5 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp View 12 chunks +19 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScriptNative.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScriptNative.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InspectedContext.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InspectedContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h View 2 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/RemoteObjectId.h View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/RemoteObjectId.cpp View 3 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h View 6 chunks +24 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp View 1 30 chunks +36 lines, -36 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h View 4 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp View 5 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp View 8 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h View 5 chunks +16 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp View 13 chunks +18 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp View 9 chunks +22 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h View 5 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp View 10 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h View 1 4 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp View 1 2 8 chunks +16 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp View 10 chunks +15 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8ContentSearchUtil.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.h View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h View 3 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8ToProtocolValue.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlay.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlay.cpp View 5 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 35 (19 generated)
pfeldman
4 years, 7 months ago (2016-05-24 18:20:46 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2004313003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2004313003/20001
4 years, 7 months ago (2016-05-24 18:25:20 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2004313003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2004313003/40001
4 years, 7 months ago (2016-05-24 18:53:27 UTC) #7
dgozman
lgtm
4 years, 7 months ago (2016-05-24 19:10:46 UTC) #8
haraken
+yutak FYI
4 years, 7 months ago (2016-05-24 19:40:18 UTC) #10
pfeldman
On 2016/05/24 19:40:18, haraken wrote: > +yutak FYI thanks. we briefly discussed it with yutak.
4 years, 7 months ago (2016-05-24 19:55:22 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/233110)
4 years, 7 months ago (2016-05-24 20:02:37 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2004313003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2004313003/40001
4 years, 7 months ago (2016-05-24 21:38:42 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/233201)
4 years, 7 months ago (2016-05-24 22:33:16 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2004313003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2004313003/60001
4 years, 7 months ago (2016-05-24 22:40:49 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/233333)
4 years, 7 months ago (2016-05-25 00:58:10 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2004313003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2004313003/60001
4 years, 7 months ago (2016-05-25 01:12:10 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2004313003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2004313003/60001
4 years, 7 months ago (2016-05-25 01:14:55 UTC) #28
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-25 01:19:55 UTC) #32
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/229b1f8945646f00a834ec88bc97fe738561ff0a Cr-Commit-Position: refs/heads/master@{#395765}
4 years, 7 months ago (2016-05-25 01:21:30 UTC) #34
Yuta Kitamura
4 years, 7 months ago (2016-05-25 03:55:23 UTC) #35
Message was sent while issue was closed.
This is great!

Powered by Google App Engine
This is Rietveld 408576698