third_party/WebKit/Source/platform/v8_inspector/InjectedScriptNative.h - Issue 2004313003: DevTools: migrate from OwnPtr to std::unique_ptr for inspector protocol classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/InjectedScriptNative.h

Issue 2004313003: DevTools: migrate from OwnPtr to std::unique_ptr for inspector protocol classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaselined Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/InjectedScriptNative.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/InjectedScriptNative.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptNative.h b/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptNative.h

index 9a80d57c2f74c47ed88b73e5b3e1a07feaca3136..435bcdb8b75c52f00729421f2954742acc27ff3d 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptNative.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptNative.h

@@ -7,7 +7,7 @@

#include "platform/inspector_protocol/Collections.h"

#include "platform/inspector_protocol/String16.h"

-#include "wtf/PassOwnPtr.h"

+#include "wtf/PtrUtil.h"

#include <v8.h>

namespace blink {

@@ -32,7 +32,7 @@ private:

int m_lastBoundObjectId;

v8::Isolate* m_isolate;

- protocol::HashMap<int, OwnPtr<v8::Global<v8::Value>>> m_idToWrappedObject;

+ protocol::HashMap<int, std::unique_ptr<v8::Global<v8::Value>>> m_idToWrappedObject;

typedef protocol::HashMap<int, String16> IdToObjectGroupName;

IdToObjectGroupName m_idToObjectGroupName;

typedef protocol::HashMap<String16, protocol::Vector<int>> NameToObjectGroup;