third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp - Issue 2004313003: DevTools: migrate from OwnPtr to std::unique_ptr for inspector protocol classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp

Issue 2004313003: DevTools: migrate from OwnPtr to std::unique_ptr for inspector protocol classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaselined Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp

index 3bbe64c16ad8b8c94e58b495a826e49c262be597..872758129d74d995d93fc8e78b6bf94f1c2a2ef0 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp

@@ -34,7 +34,7 @@

#include "platform/v8_inspector/V8DebuggerImpl.h"

#include "platform/v8_inspector/V8StringUtil.h"

#include "platform/v8_inspector/public/V8DebuggerClient.h"

-#include "wtf/PassOwnPtr.h"

+#include "wtf/PtrUtil.h"

#include <v8.h>

@@ -97,7 +97,7 @@ v8::Local<v8::Value> V8FunctionCall::callWithoutExceptionHandling()

DCHECK(value->IsFunction());

v8::Local<v8::Function> function = v8::Local<v8::Function>::Cast(value);

- OwnPtr<v8::Local<v8::Value>[]> info = adoptArrayPtr(new v8::Local<v8::Value>[m_arguments.size()]);

+ std::unique_ptr<v8::Local<v8::Value>[]> info(new v8::Local<v8::Value>[m_arguments.size()]);

for (size_t i = 0; i < m_arguments.size(); ++i) {

info[i] = m_arguments[i];

DCHECK(!info[i].IsEmpty());