third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.h - Issue 2004313003: DevTools: migrate from OwnPtr to std::unique_ptr for inspector protocol classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.h

Issue 2004313003: DevTools: migrate from OwnPtr to std::unique_ptr for inspector protocol classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaselined Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.h b/third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.h

index ef208d9b04c1dd9236513033cd733c3f224aae8f..54fe0b04ed37aa0d457117d9b81b8f1f6476c6db 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.h

@@ -31,7 +31,7 @@ public:

void disable(ErrorString*) override;

void setSamplingInterval(ErrorString*, int) override;

void start(ErrorString*) override;

- void stop(ErrorString*, OwnPtr<protocol::Profiler::CPUProfile>*) override;

+ void stop(ErrorString*, std::unique_ptr<protocol::Profiler::CPUProfile>*) override;

void consoleProfile(const String16& title);

void consoleProfileEnd(const String16& title);

@@ -40,7 +40,7 @@ private:

String16 nextProfileId();

void startProfiling(const String16& title);

- PassOwnPtr<protocol::Profiler::CPUProfile> stopProfiling(const String16& title, bool serialize);

+ std::unique_ptr<protocol::Profiler::CPUProfile> stopProfiling(const String16& title, bool serialize);

bool isRecording() const;