Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Side by Side Diff: third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h

Issue 2004313003: DevTools: migrate from OwnPtr to std::unique_ptr for inspector protocol classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebaselined Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2010, Google Inc. All rights reserved. 2 * Copyright (c) 2010, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 15 matching lines...) Expand all
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #ifndef JavaScriptCallFrame_h 31 #ifndef JavaScriptCallFrame_h
32 #define JavaScriptCallFrame_h 32 #define JavaScriptCallFrame_h
33 33
34 #include "platform/inspector_protocol/Collections.h" 34 #include "platform/inspector_protocol/Collections.h"
35 #include "platform/inspector_protocol/String16.h" 35 #include "platform/inspector_protocol/String16.h"
36 #include "wtf/OwnPtr.h" 36 #include "wtf/PtrUtil.h"
37 #include "wtf/PassOwnPtr.h"
38 #include <v8.h> 37 #include <v8.h>
39 38
40 namespace blink { 39 namespace blink {
41 40
42 class JavaScriptCallFrame { 41 class JavaScriptCallFrame {
43 public: 42 public:
44 static PassOwnPtr<JavaScriptCallFrame> create(v8::Local<v8::Context> debugge rContext, v8::Local<v8::Object> callFrame) 43 static std::unique_ptr<JavaScriptCallFrame> create(v8::Local<v8::Context> de buggerContext, v8::Local<v8::Object> callFrame)
45 { 44 {
46 return adoptPtr(new JavaScriptCallFrame(debuggerContext, callFrame)); 45 return wrapUnique(new JavaScriptCallFrame(debuggerContext, callFrame));
47 } 46 }
48 ~JavaScriptCallFrame(); 47 ~JavaScriptCallFrame();
49 48
50 int sourceID() const; 49 int sourceID() const;
51 int line() const; 50 int line() const;
52 int column() const; 51 int column() const;
53 int contextId() const; 52 int contextId() const;
54 53
55 bool isAtReturn() const; 54 bool isAtReturn() const;
56 v8::Local<v8::Object> details() const; 55 v8::Local<v8::Object> details() const;
57 56
58 v8::MaybeLocal<v8::Value> evaluate(v8::Local<v8::Value> expression); 57 v8::MaybeLocal<v8::Value> evaluate(v8::Local<v8::Value> expression);
59 v8::MaybeLocal<v8::Value> restart(); 58 v8::MaybeLocal<v8::Value> restart();
60 v8::MaybeLocal<v8::Value> setVariableValue(int scopeNumber, v8::Local<v8::Va lue> variableName, v8::Local<v8::Value> newValue); 59 v8::MaybeLocal<v8::Value> setVariableValue(int scopeNumber, v8::Local<v8::Va lue> variableName, v8::Local<v8::Value> newValue);
61 private: 60 private:
62 JavaScriptCallFrame(v8::Local<v8::Context> debuggerContext, v8::Local<v8::Ob ject> callFrame); 61 JavaScriptCallFrame(v8::Local<v8::Context> debuggerContext, v8::Local<v8::Ob ject> callFrame);
63 62
64 int callV8FunctionReturnInt(const char* name) const; 63 int callV8FunctionReturnInt(const char* name) const;
65 64
66 v8::Isolate* m_isolate; 65 v8::Isolate* m_isolate;
67 v8::Global<v8::Context> m_debuggerContext; 66 v8::Global<v8::Context> m_debuggerContext;
68 v8::Global<v8::Object> m_callFrame; 67 v8::Global<v8::Object> m_callFrame;
69 }; 68 };
70 69
71 using JavaScriptCallFrames = protocol::Vector<OwnPtr<JavaScriptCallFrame>>; 70 using JavaScriptCallFrames = protocol::Vector<std::unique_ptr<JavaScriptCallFram e>>;
72 71
73 } // namespace blink 72 } // namespace blink
74 73
75 #endif // JavaScriptCallFrame_h 74 #endif // JavaScriptCallFrame_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698