third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp - Issue 2004313003: DevTools: migrate from OwnPtr to std::unique_ptr for inspector protocol classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp

Issue 2004313003: DevTools: migrate from OwnPtr to std::unique_ptr for inspector protocol classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaselined Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/RemoteObjectId.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp

index 1ed8701510e614f3b44ef01ae197da9fb63bf7bd..342df6fbe2e0faf912006eadc6a07c88562eb20c 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp

@@ -336,7 +336,7 @@ void V8Console::countCallback(const v8::FunctionCallbackInfo<v8::Value>& info)

String16 title = helper.firstArgToString(String16());

String16 identifier;

if (title.isEmpty()) {

- OwnPtr<V8StackTraceImpl> stackTrace = V8StackTraceImpl::capture(nullptr, 1);

+ std::unique_ptr<V8StackTraceImpl> stackTrace = V8StackTraceImpl::capture(nullptr, 1);

if (stackTrace)

identifier = stackTrace->topSourceURL() + ":" + String16::number(stackTrace->topLineNumber());

} else {

@@ -589,11 +589,11 @@ static void inspectImpl(const v8::FunctionCallbackInfo<v8::Value>& info, bool co

if (!injectedScript)

return;

ErrorString errorString;

- OwnPtr<protocol::Runtime::RemoteObject> wrappedObject = injectedScript->wrapObject(&errorString, info[0], "", false /** forceValueType */, false /** generatePreview */);

+ std::unique_ptr<protocol::Runtime::RemoteObject> wrappedObject = injectedScript->wrapObject(&errorString, info[0], "", false /** forceValueType */, false /** generatePreview */);

if (!wrappedObject || !errorString.isEmpty())

return;

- OwnPtr<protocol::DictionaryValue> hints = protocol::DictionaryValue::create();

+ std::unique_ptr<protocol::DictionaryValue> hints = protocol::DictionaryValue::create();

if (copyToClipboard)

hints->setBoolean("copyToClipboard", true);

if (V8InspectorSessionImpl* session = helper.currentSession())