Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Side by Side Diff: third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h

Issue 2004313003: DevTools: migrate from OwnPtr to std::unique_ptr for inspector protocol classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebaselined Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 void disable(ErrorString*) override; 64 void disable(ErrorString*) override;
65 void evaluate(ErrorString*, 65 void evaluate(ErrorString*,
66 const String16& expression, 66 const String16& expression,
67 const Maybe<String16>& objectGroup, 67 const Maybe<String16>& objectGroup,
68 const Maybe<bool>& includeCommandLineAPI, 68 const Maybe<bool>& includeCommandLineAPI,
69 const Maybe<bool>& doNotPauseOnExceptionsAndMuteConsole, 69 const Maybe<bool>& doNotPauseOnExceptionsAndMuteConsole,
70 const Maybe<int>& executionContextId, 70 const Maybe<int>& executionContextId,
71 const Maybe<bool>& returnByValue, 71 const Maybe<bool>& returnByValue,
72 const Maybe<bool>& generatePreview, 72 const Maybe<bool>& generatePreview,
73 const Maybe<bool>& userGesture, 73 const Maybe<bool>& userGesture,
74 OwnPtr<protocol::Runtime::RemoteObject>* result, 74 std::unique_ptr<protocol::Runtime::RemoteObject>* result,
75 Maybe<bool>* wasThrown, 75 Maybe<bool>* wasThrown,
76 Maybe<protocol::Runtime::ExceptionDetails>*) override; 76 Maybe<protocol::Runtime::ExceptionDetails>*) override;
77 void callFunctionOn(ErrorString*, 77 void callFunctionOn(ErrorString*,
78 const String16& objectId, 78 const String16& objectId,
79 const String16& expression, 79 const String16& expression,
80 const Maybe<protocol::Array<protocol::Runtime::CallArgument>>& optionalA rguments, 80 const Maybe<protocol::Array<protocol::Runtime::CallArgument>>& optionalA rguments,
81 const Maybe<bool>& doNotPauseOnExceptionsAndMuteConsole, 81 const Maybe<bool>& doNotPauseOnExceptionsAndMuteConsole,
82 const Maybe<bool>& returnByValue, 82 const Maybe<bool>& returnByValue,
83 const Maybe<bool>& generatePreview, 83 const Maybe<bool>& generatePreview,
84 const Maybe<bool>& userGesture, 84 const Maybe<bool>& userGesture,
85 OwnPtr<protocol::Runtime::RemoteObject>* result, 85 std::unique_ptr<protocol::Runtime::RemoteObject>* result,
86 Maybe<bool>* wasThrown) override; 86 Maybe<bool>* wasThrown) override;
87 void releaseObject(ErrorString*, const String16& objectId) override; 87 void releaseObject(ErrorString*, const String16& objectId) override;
88 void getProperties(ErrorString*, 88 void getProperties(ErrorString*,
89 const String16& objectId, 89 const String16& objectId,
90 const Maybe<bool>& ownProperties, 90 const Maybe<bool>& ownProperties,
91 const Maybe<bool>& accessorPropertiesOnly, 91 const Maybe<bool>& accessorPropertiesOnly,
92 const Maybe<bool>& generatePreview, 92 const Maybe<bool>& generatePreview,
93 OwnPtr<protocol::Array<protocol::Runtime::PropertyDescriptor>>* result, 93 std::unique_ptr<protocol::Array<protocol::Runtime::PropertyDescriptor>>* result,
94 Maybe<protocol::Array<protocol::Runtime::InternalPropertyDescriptor>>* i nternalProperties, 94 Maybe<protocol::Array<protocol::Runtime::InternalPropertyDescriptor>>* i nternalProperties,
95 Maybe<protocol::Runtime::ExceptionDetails>*) override; 95 Maybe<protocol::Runtime::ExceptionDetails>*) override;
96 void releaseObjectGroup(ErrorString*, const String16& objectGroup) override; 96 void releaseObjectGroup(ErrorString*, const String16& objectGroup) override;
97 void run(ErrorString*) override; 97 void run(ErrorString*) override;
98 void setCustomObjectFormatterEnabled(ErrorString*, bool) override; 98 void setCustomObjectFormatterEnabled(ErrorString*, bool) override;
99 void compileScript(ErrorString*, 99 void compileScript(ErrorString*,
100 const String16& expression, 100 const String16& expression,
101 const String16& sourceURL, 101 const String16& sourceURL,
102 bool persistScript, 102 bool persistScript,
103 int executionContextId, 103 int executionContextId,
104 Maybe<String16>*, 104 Maybe<String16>*,
105 Maybe<protocol::Runtime::ExceptionDetails>*) override; 105 Maybe<protocol::Runtime::ExceptionDetails>*) override;
106 void runScript(ErrorString*, 106 void runScript(ErrorString*,
107 const String16&, 107 const String16&,
108 int executionContextId, 108 int executionContextId,
109 const Maybe<String16>& objectGroup, 109 const Maybe<String16>& objectGroup,
110 const Maybe<bool>& doNotPauseOnExceptionsAndMuteConsole, 110 const Maybe<bool>& doNotPauseOnExceptionsAndMuteConsole,
111 const Maybe<bool>& includeCommandLineAPI, 111 const Maybe<bool>& includeCommandLineAPI,
112 OwnPtr<protocol::Runtime::RemoteObject>* result, 112 std::unique_ptr<protocol::Runtime::RemoteObject>* result,
113 Maybe<protocol::Runtime::ExceptionDetails>*) override; 113 Maybe<protocol::Runtime::ExceptionDetails>*) override;
114 114
115 void reset(); 115 void reset();
116 void reportExecutionContextCreated(InspectedContext*); 116 void reportExecutionContextCreated(InspectedContext*);
117 void reportExecutionContextDestroyed(InspectedContext*); 117 void reportExecutionContextDestroyed(InspectedContext*);
118 void inspect(PassOwnPtr<protocol::Runtime::RemoteObject> objectToInspect, Pa ssOwnPtr<protocol::DictionaryValue> hints); 118 void inspect(std::unique_ptr<protocol::Runtime::RemoteObject> objectToInspec t, std::unique_ptr<protocol::DictionaryValue> hints);
119 119
120 private: 120 private:
121 V8InspectorSessionImpl* m_session; 121 V8InspectorSessionImpl* m_session;
122 protocol::DictionaryValue* m_state; 122 protocol::DictionaryValue* m_state;
123 protocol::Frontend::Runtime* m_frontend; 123 protocol::Frontend::Runtime* m_frontend;
124 V8DebuggerImpl* m_debugger; 124 V8DebuggerImpl* m_debugger;
125 bool m_enabled; 125 bool m_enabled;
126 protocol::HashMap<String16, OwnPtr<v8::Global<v8::Script>>> m_compiledScript s; 126 protocol::HashMap<String16, std::unique_ptr<v8::Global<v8::Script>>> m_compi ledScripts;
127 }; 127 };
128 128
129 } // namespace blink 129 } // namespace blink
130 130
131 #endif // V8RuntimeAgentImpl_h 131 #endif // V8RuntimeAgentImpl_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698